Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: adds SPM build to CI #697

Merged
merged 36 commits into from
Oct 5, 2023
Merged

chore: adds SPM build to CI #697

merged 36 commits into from
Oct 5, 2023

Conversation

NQuinn27
Copy link
Contributor

@NQuinn27 NQuinn27 commented Oct 3, 2023 •
edited
Loading

This PR adds the building of the Debug App using Swift Package Manager into the pipeline steps.

Project Changes:

  • Adds a new Xcode project for the SPM build
  • Adds a new Xcode scheme for Debug App SPM

Other Changes:

  • Ruby version is updated to 3.2 to facilitate a cocoapods version update
  • Cocoapods version updated to 1.13.0
  • Sonarcloud pipeline step is now appropriately named

@NQuinn27 NQuinn27 requested a review from a team as a code owner October 3, 2023 17:50
@github-actions
Copy link
Contributor

github-actions bot commented Oct 3, 2023 •
edited
Loading

Warnings
⚠️ This PR doesn't seem to contain any updated Unit Test 🤔. Please consider double checking it.🙏
⚠️ > Pull Request size seems relatively large. If this Pull Request contains multiple changes, please split each into separate PR will helps faster, easier review.
⚠️ Please assign someone aside from CODEOWNERS (@checkout-pci-reviewers) to review this PR.

Generated by 🚫 Danger Swift against 05864e6

@NQuinn27 NQuinn27 marked this pull request as draft October 3, 2023 19:32
@github-actions
Copy link
Contributor

github-actions bot commented Oct 3, 2023 •
edited
Loading

Appetize link: https://appetize.io/app/5f5fpv2gfl6ghkdnris3kq76ki

@NQuinn27 NQuinn27 requested a review from borisprimer October 4, 2023 14:43
@NQuinn27 NQuinn27 marked this pull request as ready for review October 4, 2023 14:57
@NQuinn27 NQuinn27 requested a review from xevious78 October 4, 2023 15:09
boris-nikolic
boris-nikolic approved these changes Oct 4, 2023
View reviewed changes
Copy link

@boris-nikolic boris-nikolic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💪

@NQuinn27 NQuinn27 merged commit 8dbd904 into master Oct 5, 2023
7 checks passed
@NQuinn27 NQuinn27 deleted the nq/CHKT-1784_SPM_Sample_app branch October 5, 2023 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@boris-nikolic boris-nikolic boris-nikolic approved these changes

@xevious78 xevious78 xevious78 approved these changes

@borisprimer borisprimer Awaiting requested review from borisprimer

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@NQuinn27 @xevious78 @boris-nikolic @borisprimer