Support outerLoopNames parameter in DC Load Flow #1159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
jeandemanged
changed the title
jeandemanged
requested changes
Jan 3, 2025
There was a problem hiding this comment.
- move all xxxxxOuterLoopConfig classes from
com.powsybl.openloadflowto new packagecom.powsybl.openloadflow.lf.outerloop.config - please enhance
outerLoopNamesdescription indocs/loadflow/parameters.md: mention used for both AC and DC, and list the currently existing outer loops. - please address the Sonar reported issues
jeandemanged
reviewed
Jan 3, 2025
src/main/java/com/powsybl/openloadflow/lf/outerloop/config/OuterLoopConfig.java
Outdated
Show resolved
Hide resolved
vmouradian
force-pushed
the
feature/dc-outerloop-name-param
branch
from
aa5b091 to
967b179
Compare
Signed-off-by: vmouradian <[email protected]>
Signed-off-by: vmouradian <[email protected]>
Signed-off-by: vmouradian <[email protected]>
…g + use right static access for names Signed-off-by: vmouradian <[email protected]>
Signed-off-by: vmouradian <[email protected]>
Signed-off-by: vmouradian <[email protected]>
Signed-off-by: vmouradian <[email protected]>
Signed-off-by: vmouradian <[email protected]>
vmouradian
force-pushed
the
feature/dc-outerloop-name-param
branch
from
967b179 to
b666c0b
Compare
vmouradian
changed the title
Signed-off-by: Damien Jeandemange <[email protected]>
jeandemanged
approved these changes
Jan 16, 2025
jeandemanged
changed the title
Signed-off-by: Damien Jeandemange <[email protected]>
|
Please retry analysis of this Pull-Request directly on SonarQube Cloud |
| @@ -33,7 +33,7 @@ public DcAreaInterchangeControlOuterLoop(ActivePowerDistribution activePowerDist | |||
|
|
|||
| @Override | |||
| public String getName() { | |||
| return "AreaInterchangeControl"; | |||
There was a problem hiding this comment.
This method getName() can be moved to the parent abstract class AbstractAreaInterchangeControlOuterLoop
| @@ -37,7 +37,7 @@ public DcIncrementalPhaseControlOuterLoop() { | |||
|
|
|||
| @Override | |||
| public String getName() { | |||
| return "DC Incremental phase control"; | |||
There was a problem hiding this comment.
Same here with the class AbstractIncrementalPhaseControlOuterLoop
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
No
What kind of change does this PR introduce?
Feature
What is the current behavior?
outerLoopNamesparameter has no impact on outer loops creation in DC load flowWhat is the new behavior (if this is a feature change)?
outerLoopNamesparameter is usable to select outer loops in DC load flow, similarly to what exists for ACDoes this PR introduce a breaking change or deprecate an API?
If yes, please check if the following requirements are fulfilled
What changes might users need to make in their application due to this PR? (migration steps)
If you were configuring AC outerloops by providing a custom
OuterLoopConfigimplementation via the Java Service Loader, you will need to implementcom.powsybl.openloadflow.lf.outerloop.config.AcOuterLoopsConfigreplacing of the formercom.powsybl.openloadflow.OuterLoopConfig.If you want to also configure DC outerloops by providing a custom implementation via the Java Service Loader, you will need to implement
com.powsybl.openloadflow.lf.outerloop.config.DcOuterLoopsConfig.