Refactor DC Outer Loops creation #1158
Open
+63
−45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: vmouradian <[email protected]>
Signed-off-by: vmouradian <[email protected]>
Signed-off-by: vmouradian <[email protected]>
Signed-off-by: vmouradian <[email protected]>
vmouradian
changed the title
Signed-off-by: vmouradian <[email protected]>
|
|
Support of OuterLoopNames parameters for DC is in this separated PR : #1159. |
jeandemanged
requested changes
Jan 3, 2025
Comment on lines
+188
to
+191
| // remove area interchange control outer loop if no area in the network, active power will be distributed with classical slack distribution | ||
| boolean areaInterchangeControl = outerLoops.stream().anyMatch(DcAreaInterchangeControlOuterLoop.class::isInstance); | ||
| if (!network.hasArea()) { | ||
| outerLoops.removeIf(DcAreaInterchangeControlOuterLoop.class::isInstance); |
There was a problem hiding this comment.
don't remove the outerloop here.
the outerloop should handle the 'no area' situation by itself.
| implements OuterLoop<V, E, P, C, O>, ActivePowerDistributionOuterLoop<V, E, P, C, O> { | ||
| implements ActivePowerDistributionOuterLoop<V, E, P, C, O> { |
There was a problem hiding this comment.
since AbstractActivePowerDistributionOuterLoop implements ActivePowerDistributionOuterLoop, this part is redundant and can be removed too
implements ActivePowerDistributionOuterLoop<V, E, P, C, O>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
Part of #1091 + adds consistency (imo)
What kind of change does this PR introduce?
Feature / refactor
What is the new behavior (if this is a feature change)?
DC Outerloops creation is made more consistent with AC ones (created in the OLF parameters class then are contained in DcLoadFlowParameters)
Support of
outerLoopNamesparameter for DC is in this separated PR : #1159.Does this PR introduce a breaking change or deprecate an API?