powsybl-ws-dependencies 2.7.0 #128
Conversation
Signed-off-by: BOUHOURS Antoine <[email protected]>
src/main/java/com/powsybl/network/conversion/server/GeneratorActivePowerControlSerDe.java
Outdated
Show resolved
Hide resolved
src/main/java/com/powsybl/network/conversion/server/GeneratorActivePowerControlSerDe.java
Outdated
Show resolved
Hide resolved
src/main/java/com/powsybl/network/conversion/server/GeneratorActivePowerControlSerDe.java
Outdated
Show resolved
Hide resolved
src/main/java/com/powsybl/network/conversion/server/GeneratorShortCircuitsSerDe.java
Outdated
Show resolved
Hide resolved
src/main/java/com/powsybl/network/conversion/server/GeneratorShortCircuitsSerDe.java
Outdated
Show resolved
Hide resolved
src/test/java/com/powsybl/network/conversion/server/NetworkConversionTest.java
Outdated
Show resolved
Hide resolved
src/main/java/com/powsybl/network/conversion/server/GeneratorActivePowerControlSerDe.java
Show resolved
Hide resolved
Signed-off-by: BOUHOURS Antoine <[email protected]>
antoinebhs
force-pushed
the
update_powsybl-ws-dependencies_2.7.0
branch
from
22be149 to
74a0474
Compare
|
|
||
| @Override | ||
| public void write(ActivePowerControl activePowerControl, SerializerContext serializerContext) { | ||
| throw new IllegalStateException("Should never be called"); |
There was a problem hiding this comment.
use the same message everywhere "should not happen" or "should never be called" (I know it was already like this before but it's weird no ?)
There was a problem hiding this comment.
I agree with you but these 3 classes (GeneratorActivePowerControlSerDe.java, GeneratorShortCircuitsSerDe.java,VoltageLevelShortCircuitsSerDe.java) are duplicated from rte-core/iidm-cvg-extensions. I added a comment at the top of the 3 files to make it clearer.
I think we should not change the message to be consistent with the private repository rte-core/iidm-cvg-extensions.
Signed-off-by: BOUHOURS Antoine <[email protected]>
|
No description provided.