Review comments

Signed-off-by: BOUHOURS Antoine <[email protected]>
powsybl · Jan 31, 2024 · 22be149 · 22be149
1 parent 34cb6c5
commit 22be149
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 8 deletions.
diff --git a/src/main/java/com/powsybl/network/conversion/server/GeneratorActivePowerControlSerDe.java b/src/main/java/com/powsybl/network/conversion/server/GeneratorActivePowerControlSerDe.java
@@ -1,5 +1,5 @@
 /**
- * Copyright (c) 2022, RTE (http://www.rte-france.com)
+ * Copyright (c) 2024, RTE (http://www.rte-france.com)
  * This Source Code Form is subject to the terms of the Mozilla Public
  * License, v. 2.0. If a copy of the MPL was not distributed with this
  * file, You can obtain one at http://mozilla.org/MPL/2.0/.
@@ -17,7 +17,8 @@
 import com.powsybl.iidm.network.extensions.ActivePowerControlAdder;
 
 /**
- * @author Geoffroy Jamgotchian <geoffroy.jamgotchian at rte-france.com>
+ *  HACK!!! this class should be included in iidm-cvg-extensions. To remove when handled in rte-core.
+ * @author Antoine Bouhours <antoine.bouhours at rte-france.com>
  */
 @AutoService(ExtensionSerDe.class)
 public class GeneratorActivePowerControlSerDe<T extends Injection<T>> extends AbstractExtensionSerDe<T, ActivePowerControl<T>> {

diff --git a/src/main/java/com/powsybl/network/conversion/server/GeneratorShortCircuitsSerDe.java b/src/main/java/com/powsybl/network/conversion/server/GeneratorShortCircuitsSerDe.java
@@ -1,5 +1,5 @@
 /**
- * Copyright (c) 2023, RTE (http://www.rte-france.com)
+ * Copyright (c) 2024, RTE (http://www.rte-france.com)
  * This Source Code Form is subject to the terms of the Mozilla Public
  * License, v. 2.0. If a copy of the MPL was not distributed with this
  * file, You can obtain one at http://mozilla.org/MPL/2.0/.
@@ -17,7 +17,7 @@
 import com.powsybl.iidm.network.extensions.GeneratorShortCircuitAdder;
 
 /**
- * @author Miora Vedelago <miora.ralambotiana at rte-france.com>
+ * @author Antoine Bouhours <antoine.bouhours at rte-france.com>
  */
 @AutoService(ExtensionSerDe.class)
 public class GeneratorShortCircuitsSerDe extends AbstractExtensionSerDe<Generator, GeneratorShortCircuit> {

diff --git a/src/test/java/com/powsybl/network/conversion/server/NetworkConversionTest.java b/src/test/java/com/powsybl/network/conversion/server/NetworkConversionTest.java
@@ -17,9 +17,7 @@
 import com.powsybl.commons.reporter.ReporterModel;
 import com.powsybl.iidm.network.*;
 import com.powsybl.iidm.serde.XMLImporter;
-import com.powsybl.network.conversion.server.dto.BoundaryInfos;
-import com.powsybl.network.conversion.server.dto.CaseInfos;
-import com.powsybl.network.conversion.server.dto.EquipmentInfos;
+import com.powsybl.network.conversion.server.dto.*;
 import com.powsybl.network.store.client.NetworkStoreService;
 import com.powsybl.network.store.client.PreloadingStrategy;
 import com.powsybl.network.store.iidm.impl.NetworkFactoryImpl;
@@ -56,7 +54,9 @@
 import static org.mockito.BDDMockito.given;
 import static org.mockito.Mockito.doThrow;
 import static org.mockito.Mockito.verify;
-import static org.springframework.test.web.servlet.request.MockMvcRequestBuilders.*;
+import static org.springframework.test.web.servlet.request.MockMvcRequestBuilders.get;
+import static org.springframework.test.web.servlet.request.MockMvcRequestBuilders.head;
+import static org.springframework.test.web.servlet.request.MockMvcRequestBuilders.post;
 import static org.springframework.test.web.servlet.result.MockMvcResultMatchers.content;
 import static org.springframework.test.web.servlet.result.MockMvcResultMatchers.status;