Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correctly check for sandbox on apps page, fix relative date functions #4584

Merged
merged 2 commits into from
Apr 26, 2024
Merged

Correctly check for sandbox on apps page, fix relative date functions #4584

merged 2 commits into from
Apr 26, 2024

Conversation

MauAraujo
Copy link
Contributor

@MauAraujo MauAraujo commented Apr 26, 2024 •
edited
Loading

POR-

What does this PR do?

This PR fixes two issues:

  • If a user doesn't have a payment method but a trial is active, they are able to use the dashboard, but when they try to deploy an app they will get a blocking modal asking for payment. This is because we didn't check for the sandbox_enabled property in the project.
  • There was a weird bug with the relative time functions where if a data was between 8 months and a year, it displayed "8 months" every time. This PR changes those functions to use the dayjs library instead.

@MauAraujo MauAraujo merged commit 6faaf53 into master Apr 26, 2024
9 checks passed
@MauAraujo MauAraujo deleted the payment-modal-sanbox-flag branch April 26, 2024 19:37
@MauAraujo MauAraujo mentioned this pull request Apr 29, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ferozemohideen ferozemohideen ferozemohideen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MauAraujo @ferozemohideen