Use date-fns for relative time functions #4583
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ianedwards
approved these changes
Apr 26, 2024
| } | ||
|
|
||
| return true; | ||
| return isPast(new Date(timestamp)) ? true : false; |
There was a problem hiding this comment.
return isPast(new Date(timestamp))
|
Closing in favor of #4584 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
POR-
What does this PR do?
The existing function in the code that we were using to display relative time formats had a bug where if the date was between 8 months and a year, it displayed "8 months" regardless of the actual difference. The rest of dates were displayed correctly, but to avoid any future problems I instead change those function to use the
date-fnslibrary.