Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: re-organize code #143

Merged
merged 221 commits into from
Oct 26, 2023
Merged

refactor: re-organize code #143

Show file tree
Hide file tree
Changes from 219 commits
Commits
Show all changes
221 commits
Select commit Hold shift + click to select a range
3415941
refactor: move the wrapper to its own crate
KSXGitHub Oct 5, 2023
92fadde
refactor: move symlink_pkg to package_manager
KSXGitHub Oct 5, 2023
16ab5e5
chore(git): merge from main
KSXGitHub Oct 5, 2023
9604f46
refactor: move auto_import
KSXGitHub Oct 6, 2023
751c943
refactor: rearrange dependencies
KSXGitHub Oct 6, 2023
05e7928
refactor: move create_virtdir_by_snapshot
KSXGitHub Oct 6, 2023
1cca0c5
refactor: rename a mod
KSXGitHub Oct 6, 2023
3d81563
refactor: move import package
KSXGitHub Oct 6, 2023
4db8e06
refactor: remove unused enum variant
KSXGitHub Oct 6, 2023
a58343c
refactor: use better names
KSXGitHub Oct 6, 2023
92e9eea
docs: link_file
KSXGitHub Oct 6, 2023
207a87d
refactor: move link_file to its own mod
KSXGitHub Oct 6, 2023
5155f95
docs: correction
KSXGitHub Oct 6, 2023
e1ea5fc
chore(git): merge from main
KSXGitHub Oct 9, 2023
f2e8f45
chore(cargo): move junction to dev-dependencies
KSXGitHub Oct 9, 2023
8b00c83
chore(cargo): make `junction` windows-only
KSXGitHub Oct 9, 2023
abfaddb
refactor: rename
KSXGitHub Oct 9, 2023
61f00d3
refactor: break a function into 2
KSXGitHub Oct 9, 2023
a6cdcf5
feat: propagate an error
KSXGitHub Oct 9, 2023
673c0d8
refactor: convert a function into a struct
KSXGitHub Oct 9, 2023
03d1f8b
docs: CreateVirtualDirError
KSXGitHub Oct 9, 2023
f63a429
style: mark procedure structs as `must_use`
KSXGitHub Oct 9, 2023
0fc1603
refactor: reuse create_cas_files in ImportPackage
KSXGitHub Oct 9, 2023
5890ab1
docs: ImportPackage
KSXGitHub Oct 9, 2023
f70a8a0
feat: SymlinkPackageError
KSXGitHub Oct 9, 2023
6080fe4
refactor: reuse symlink_pkg
KSXGitHub Oct 9, 2023
673c336
feat: propagate an error
KSXGitHub Oct 9, 2023
f61eaff
feat: panic on error
KSXGitHub Oct 9, 2023
8cfda54
refactor: move symlink_pkg statement out of match
KSXGitHub Oct 9, 2023
f7fd47e
docs: ImportPackageError
KSXGitHub Oct 9, 2023
0290a15
docs: ImportPackage::import_pkg
KSXGitHub Oct 9, 2023
e669aaf
chore(git): merge from main
KSXGitHub Oct 9, 2023
fa20e05
refactor: move import_method to create_cas_files
KSXGitHub Oct 9, 2023
b853ba6
refactor: consistent naming
KSXGitHub Oct 9, 2023
e985e3d
fix(ci): micro-benchmark
KSXGitHub Oct 10, 2023
12cace8
fix(ci): micro-benchmark
KSXGitHub Oct 10, 2023
9fd3abb
refactor: remove ImportPackage
KSXGitHub Oct 10, 2023
d55c056
refactor: fix a name
KSXGitHub Oct 10, 2023
123137d
refactor: explicit error conversion
KSXGitHub Oct 10, 2023
0cb6cef
refactor: remove unused error variant
KSXGitHub Oct 10, 2023
0f502f9
fix(ci): micro-benchmark (again)
KSXGitHub Oct 10, 2023
b1ab7d0
fix(ci): micro-benchmark (again)
KSXGitHub Oct 10, 2023
80c6999
fix(benchmark): fixture path
KSXGitHub Oct 10, 2023
e9185e4
fix(benchmark): fixture path
KSXGitHub Oct 10, 2023
b11de0f
chore(git): merge from main
KSXGitHub Oct 10, 2023
adbba37
refactor: move a function
KSXGitHub Oct 10, 2023
ddeb577
docs: an unwrap
KSXGitHub Oct 10, 2023
a7494bc
refactor: InstallSinglePkgToVirtualDir
KSXGitHub Oct 10, 2023
aeaa479
docs: InstallSinglePkgToVirtualDir
KSXGitHub Oct 10, 2023
36a300b
docs: summary should be in one paragraph.
KSXGitHub Oct 10, 2023
7e7a6af
docs: unwrap
KSXGitHub Oct 10, 2023
f009373
docs: plan
KSXGitHub Oct 10, 2023
87973db
docs: note the necessity
KSXGitHub Oct 11, 2023
3810d27
perf(install): skip requesting index when pinned
KSXGitHub Oct 11, 2023
00d49de
refactor: change match to if let
KSXGitHub Oct 11, 2023
038abe9
refactor: remove fetch_package_version_directly
KSXGitHub Oct 11, 2023
a97254d
docs: remove a TODO
KSXGitHub Oct 11, 2023
6f95853
docs: planning
KSXGitHub Oct 11, 2023
2b79f20
docs: change the plan
KSXGitHub Oct 11, 2023
3d3131d
feat: PackageTag
KSXGitHub Oct 12, 2023
419c10f
docs: missing feature
KSXGitHub Oct 12, 2023
c65e51f
refactor: rename some variables
KSXGitHub Oct 12, 2023
35371b7
refactor: guard against error
KSXGitHub Oct 12, 2023
240b9a1
docs: remove outdated TODO
KSXGitHub Oct 12, 2023
2d04a8d
refactor: rename
KSXGitHub Oct 12, 2023
6c81425
refactor: stop using `pkg`
KSXGitHub Oct 12, 2023
a1110d6
docs: InstallPackageBySnapshotError
KSXGitHub Oct 12, 2023
d4803fd
refactor: move a function
KSXGitHub Oct 12, 2023
2f4a2e1
refactor: InstallPackageFromRegistry
KSXGitHub Oct 12, 2023
d909f97
refactor: turn `internal_fetch` into a method
KSXGitHub Oct 12, 2023
fcaa74e
refactor: rename a method
KSXGitHub Oct 12, 2023
b6b1a52
refactor: correct a field name
KSXGitHub Oct 12, 2023
c26c9e7
docs: InstallPackageFromRegistryError
KSXGitHub Oct 12, 2023
26c9f40
docs: fields
KSXGitHub Oct 12, 2023
21787a4
docs: linkify
KSXGitHub Oct 12, 2023
8ed7199
refactor: rearrange some fields
KSXGitHub Oct 12, 2023
4d0f6d4
refactor: move a function
KSXGitHub Oct 12, 2023
ae3c114
refactor: mod should have same name
KSXGitHub Oct 12, 2023
e2d2965
refactor: move a function
KSXGitHub Oct 12, 2023
cbe6b11
refactor: consistent method naming
KSXGitHub Oct 12, 2023
8b2bb8c
refactor: move a code section
KSXGitHub Oct 13, 2023
daecbfd
docs: InstallFrozenLockfile
KSXGitHub Oct 13, 2023
5bdeeb6
refactor: star export
KSXGitHub Oct 13, 2023
edcf147
refactor: destructure
KSXGitHub Oct 13, 2023
2a2787f
refactor: InstallWithoutLockfile
KSXGitHub Oct 13, 2023
54445c6
refactor(test): remove unnecessary tempdir
KSXGitHub Oct 13, 2023
1625a23
refactor: reuse
KSXGitHub Oct 13, 2023
e6a7268
refactor: remove fake mut
KSXGitHub Oct 13, 2023
2999bf9
refactor: move code from install
KSXGitHub Oct 13, 2023
742a6e2
refactor(test): move
KSXGitHub Oct 13, 2023
4807700
docs: remove useless comment
KSXGitHub Oct 13, 2023
7f72108
refactor: make add reuse install
KSXGitHub Oct 13, 2023
050e2b4
fix(windows): missing dependencies
KSXGitHub Oct 13, 2023
ea6207c
refactor(test): move util functions to a crate
KSXGitHub Oct 13, 2023
d31beab
style: remove some empty lines
KSXGitHub Oct 13, 2023
896f30d
chore: remove unused file
KSXGitHub Oct 13, 2023
2e1c00d
refactor(test): move a function to utils
KSXGitHub Oct 13, 2023
8fcc5a9
docs: move the brief overview
KSXGitHub Oct 13, 2023
2730577
docs: brief overview for frozen lockfile algorithm
KSXGitHub Oct 13, 2023
e8be328
style: merge imports
KSXGitHub Oct 13, 2023
c42730d
refactor: rename cli types
KSXGitHub Oct 13, 2023
764c744
style: fix imports
KSXGitHub Oct 13, 2023
2be4d72
refactor: rename
KSXGitHub Oct 13, 2023
e5a8cef
refactor: rename files
KSXGitHub Oct 13, 2023
4178483
style: merge imports
KSXGitHub Oct 13, 2023
9a88dd3
refactor: rename
KSXGitHub Oct 13, 2023
75a7a85
style: shorten import line
KSXGitHub Oct 13, 2023
05a7cab
refactor: rename
KSXGitHub Oct 14, 2023
b498a0c
refactor: group dependency options together
KSXGitHub Oct 14, 2023
2e277dd
style: consistent derive order
KSXGitHub Oct 14, 2023
ba691f1
style: consistent derive order
KSXGitHub Oct 14, 2023
c3ab708
style: use clap attribute
KSXGitHub Oct 14, 2023
ab6fbd6
refactor: use iterator to list dependency groups
KSXGitHub Oct 14, 2023
7cc6ffb
docs: correction
KSXGitHub Oct 14, 2023
829041c
docs: AddDependencyOptions::dependency_groups
KSXGitHub Oct 14, 2023
70833b9
docs(test): correct a name
KSXGitHub Oct 14, 2023
93be4aa
test: AddDependencyOptions::dependency_groups
KSXGitHub Oct 14, 2023
1c8a86b
refactor: derive less
KSXGitHub Oct 14, 2023
ed78c9d
refactor: stop using `mod.rs`
KSXGitHub Oct 14, 2023
9048cce
style(test): remove unnecessary pub
KSXGitHub Oct 14, 2023
6e75b1f
refactor: make dependency_groups private
KSXGitHub Oct 14, 2023
3efa05d
refactor(cli): remove explicit longs
KSXGitHub Oct 14, 2023
206b705
refactor(cli): use clap attribute
KSXGitHub Oct 14, 2023
6e3ff87
feat(cli): don't eagerly call current_dir
KSXGitHub Oct 14, 2023
90e45a7
refactor: move some code
KSXGitHub Oct 14, 2023
3604c98
refactor: move error types closer to their users
KSXGitHub Oct 14, 2023
436356a
refactor: remove unused clap groups
KSXGitHub Oct 14, 2023
ccdea75
refactor: rename error variants
KSXGitHub Oct 14, 2023
e4fa7c4
feat(cli): propagate an error
KSXGitHub Oct 14, 2023
77b64bd
style: prefer use statements
KSXGitHub Oct 14, 2023
232cae6
style: merge imports
KSXGitHub Oct 14, 2023
e4d66fe
chore(cargo): remove unused dependencies
KSXGitHub Oct 14, 2023
efc2068
refactor(cli): import directly
KSXGitHub Oct 14, 2023
58d12f9
refactor: remove unused type aliases
KSXGitHub Oct 14, 2023
c627b82
refactor: remove re-export of macro-only crate
KSXGitHub Oct 14, 2023
b1b0bdb
refactor: use the crates directly
KSXGitHub Oct 14, 2023
ca00e24
refactor(executor): use derive_more
KSXGitHub Oct 14, 2023
35b6db4
feat(executor): distinct error variants
KSXGitHub Oct 14, 2023
147ff46
fix: compile error
KSXGitHub Oct 14, 2023
a9206da
refactor(test): proper integration test
KSXGitHub Oct 14, 2023
24e4a8e
test(cli): package.json
KSXGitHub Oct 14, 2023
3a5c86d
test(cli): proper integration test
KSXGitHub Oct 14, 2023
ba57918
test(cli): change titles
KSXGitHub Oct 14, 2023
9008979
test(cli): add missing title
KSXGitHub Oct 14, 2023
caeabd2
refactor(test): reuse code
KSXGitHub Oct 14, 2023
c635468
test(cli): proper integration test
KSXGitHub Oct 14, 2023
ab25256
test(cli): add a title
KSXGitHub Oct 14, 2023
447b899
test(cli): integration test for `pacquet install`
KSXGitHub Oct 14, 2023
1769c60
test(cli): change title
KSXGitHub Oct 14, 2023
db05100
test(cli): proper integration test
KSXGitHub Oct 14, 2023
1f7fdcc
test(cli): proper integration test
KSXGitHub Oct 14, 2023
98ba757
refactor(cli): rename `cli_command` to `cli_args`
KSXGitHub Oct 14, 2023
8be20ea
feat(cli): only load .npmrc when necessary
KSXGitHub Oct 14, 2023
e15900c
fix(test): forgot to set current_dir
KSXGitHub Oct 14, 2023
7824b31
test(cli): init
KSXGitHub Oct 14, 2023
086af30
refactor(test): share code
KSXGitHub Oct 14, 2023
58de7e0
test(cli): remove nonsensical test
KSXGitHub Oct 14, 2023
73f6c08
test(cli): pacquet store path
KSXGitHub Oct 14, 2023
0a2fd52
refactor(test): remove mut
KSXGitHub Oct 14, 2023
15a8946
refactor(test): remove unnecessary action
KSXGitHub Oct 14, 2023
cabff79
refactor(cli): attach code to respective args
KSXGitHub Oct 14, 2023
e1ee4eb
refactor(cli): remove methods from PackageManager
KSXGitHub Oct 14, 2023
3dd9794
refactor: rename `PackageManager` to `State`
KSXGitHub Oct 14, 2023
1d183db
refactor: use
KSXGitHub Oct 14, 2023
6d4df48
feat(npmrc): PackageJson::path
KSXGitHub Oct 14, 2023
7dbf11a
feat(npmrc): lifetime
KSXGitHub Oct 14, 2023
5189c82
refactor(cli): pass the state
KSXGitHub Oct 14, 2023
509c368
refactor(npmrc): dependency injection
KSXGitHub Oct 14, 2023
45e802c
docs: what's wrong
KSXGitHub Oct 14, 2023
ce0369a
fix(npmrc): the algorithm
KSXGitHub Oct 14, 2023
636229b
style: move error type closer to its user
KSXGitHub Oct 15, 2023
fce5673
refactor: use derive_more
KSXGitHub Oct 15, 2023
1b1a760
refactor(cli): lazy package_json_path
KSXGitHub Oct 15, 2023
ce93200
refactor: be explicit
KSXGitHub Oct 15, 2023
28d3695
refactor: destroy args on use
KSXGitHub Oct 15, 2023
0a91d1e
refactor: remove early return
KSXGitHub Oct 15, 2023
206a8b7
refactor(cli): attach code to args
KSXGitHub Oct 15, 2023
f89a5f9
docs(cli): State
KSXGitHub Oct 15, 2023
d5dc166
docs: fields of State
KSXGitHub Oct 15, 2023
bc73b25
style: rearrange the fields
KSXGitHub Oct 15, 2023
3e6e49b
refactor: convert a function to a struct
KSXGitHub Oct 15, 2023
02ee0b2
docs: DownloadTarballToStore
KSXGitHub Oct 15, 2023
d48d908
refactor: name error by step it happens
KSXGitHub Oct 15, 2023
1cb3822
refactor: use derive_more
KSXGitHub Oct 15, 2023
246b488
fix(test): macOS on CI
KSXGitHub Oct 15, 2023
c25d9c8
chore(cargo): use [email protected]
KSXGitHub Oct 15, 2023
8d80da3
fix(test): windows
KSXGitHub Oct 15, 2023
05870a3
chore: remove accidental file
KSXGitHub Oct 15, 2023
5088dac
chore(cargo): remove unused dependency
KSXGitHub Oct 15, 2023
1a0d2c8
fix(test): windows, again
KSXGitHub Oct 15, 2023
9b17091
chore(cargo): remove unused dependency
KSXGitHub Oct 15, 2023
ca110d9
refactor: replace `thiserror` with `derive_more`
KSXGitHub Oct 15, 2023
4025766
fix(test): windows, macos
KSXGitHub Oct 15, 2023
11924f4
refactor: use getters
KSXGitHub Oct 16, 2023
11dfe1b
refactor: remove unnecessary `pub`
KSXGitHub Oct 16, 2023
0ad43b2
refactor: remove unnecessary `pub`
KSXGitHub Oct 16, 2023
886f1d4
refactor: rename DependencyGroup::{Default -> Prod}
KSXGitHub Oct 16, 2023
1aee2a3
docs: future plan
KSXGitHub Oct 16, 2023
ea79141
docs: list_dependency_groups
KSXGitHub Oct 16, 2023
e877d1d
docs: why it is that way it is
KSXGitHub Oct 16, 2023
86b52d9
docs: future plan
KSXGitHub Oct 16, 2023
5f953bb
refactor: rename PackageJson to PackageManifest
KSXGitHub Oct 16, 2023
de034f9
docs: PackageManifest
KSXGitHub Oct 16, 2023
a04e42e
refactor: rename fields and variables
KSXGitHub Oct 16, 2023
601a90f
style: cargo fmt
KSXGitHub Oct 16, 2023
a38bb0b
refactor: rename more
KSXGitHub Oct 16, 2023
3fc1938
style: consistent crate dir name
KSXGitHub Oct 16, 2023
075e788
refactor: use kebab-case where possible
KSXGitHub Oct 16, 2023
c6e1a77
fix(ci): check all docs
KSXGitHub Oct 16, 2023
9f6204f
fix(ci): micro-benchmark
KSXGitHub Oct 16, 2023
c25d2b3
docs: remove redundant comment
KSXGitHub Oct 16, 2023
400eb55
refactor: rename `package` to `package_name`
KSXGitHub Oct 16, 2023
bc9a454
docs: future plan
KSXGitHub Oct 16, 2023
7ba09df
docs: remove from fields
KSXGitHub Oct 16, 2023
f6f5c40
chore(git): merge from main
KSXGitHub Oct 16, 2023
78c4e1c
fix(clippy): windows
KSXGitHub Oct 16, 2023
4e8463b
docs(cli): remove a "pacquet" mention
KSXGitHub Oct 16, 2023
5a7ed67
docs: future plan
KSXGitHub Oct 16, 2023
c82a2a7
chore(git): pull
KSXGitHub Oct 16, 2023
8ea5089
chore(git): merge from main
KSXGitHub Oct 17, 2023
47b3fa0
chore(git): merge from main
KSXGitHub Oct 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/micro-benchmark.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ jobs:
shared-key: micro-benchmark

- name: Compile
run: cargo build --release -p pacquet_micro_benchmark
run: cargo build --release --bin=micro-benchmark

- name: Sleep for CPU cooldown
shell: bash
Expand All @@ -48,7 +48,7 @@ jobs:
ref: ${{ github.event.pull_request.head.sha }}

- name: Compile
run: cargo build --release -p pacquet_micro_benchmark
run: cargo build --release --bin=micro-benchmark

- name: Sleep for CPU cooldown
shell: bash
Expand Down
Loading