Code

refactor: re-organize code#143

Code

Merged

zkochan merged 221 commits intomainpnpm/pacquet:mainfrom big-refactorpnpm/pacquet:big-refactorCopy head branch name to clipboardOct 26, 2023

+2,795-1,865

Commits

Commits on Oct 5, 2023

• refactor: move the wrapper to its own crate

  KSXGitHub

  committed
  3415941

• refactor: move symlink_pkg to package_manager

  KSXGitHub

  committed
  92fadde

• chore(git): merge from main

  KSXGitHub

  committed
  16ab5e5

Commits on Oct 6, 2023

• refactor: move auto_import

  KSXGitHub

  committed
  9604f46

• refactor: rearrange dependencies

  KSXGitHub

  committed
  751c943

• refactor: move create_virtdir_by_snapshot

  KSXGitHub

  committed
  05e7928

• refactor: rename a mod

  KSXGitHub

  committed
  1cca0c5

• refactor: move import package

  KSXGitHub

  committed
  3d81563

• refactor: remove unused enum variant

  KSXGitHub

  committed
  4db8e06

• refactor: use better names

  KSXGitHub

  committed
  a58343c

• docs: link_file

  KSXGitHub

  committed
  92e9eea

• refactor: move link_file to its own mod

  KSXGitHub

  committed
  207a87d

• docs: correction

  KSXGitHub

  committed
  5155f95

Commits on Oct 9, 2023

• chore(git): merge from main

  KSXGitHub

  committed
  e1ea5fc

• chore(cargo): move junction to dev-dependencies

  KSXGitHub

  committed
  f2e8f45

• chore(cargo): make junction windows-only

  KSXGitHub

  committed
  8b00c83

• refactor: rename

  KSXGitHub

  committed
  abfaddb

• refactor: break a function into 2

  KSXGitHub

  committed
  61f00d3

• feat: propagate an error

  KSXGitHub

  committed
  a6cdcf5

• refactor: convert a function into a struct

  KSXGitHub

  committed
  673c0d8

• docs: CreateVirtualDirError

  KSXGitHub

  committed
  03d1f8b

• style: mark procedure structs as must_use

  KSXGitHub

  committed
  f63a429

• refactor: reuse create_cas_files in ImportPackage

  KSXGitHub

  committed
  0fc1603

• docs: ImportPackage

  KSXGitHub

  committed
  5890ab1

• feat: SymlinkPackageError

  KSXGitHub

  committed
  f70a8a0

• refactor: reuse symlink_pkg

  KSXGitHub

  committed
  6080fe4

• feat: propagate an error

  KSXGitHub

  committed
  673c336

• feat: panic on error

  KSXGitHub

  committed
  f61eaff

• refactor: move symlink_pkg statement out of match

  Show description for 8cfda54
  KSXGitHub

  committed
  8cfda54

• docs: ImportPackageError

  KSXGitHub

  committed
  f7fd47e

• docs: ImportPackage::import_pkg

  KSXGitHub

  committed
  0290a15

• chore(git): merge from main

  KSXGitHub

  committed
  e669aaf

• refactor: move import_method to create_cas_files

  KSXGitHub

  committed
  fa20e05

• refactor: consistent naming

  KSXGitHub

  committed
  b853ba6

Commits on Oct 10, 2023

• fix(ci): micro-benchmark

  Show description for e985e3d
  KSXGitHub

  committed
  e985e3d

• fix(ci): micro-benchmark

  KSXGitHub

  committed
  12cace8

• refactor: remove ImportPackage

  KSXGitHub

  committed
  9fd3abb

• refactor: fix a name

  KSXGitHub

  committed
  d55c056

• refactor: explicit error conversion

  Show description for 123137d
  KSXGitHub

  committed
  123137d

• refactor: remove unused error variant

  KSXGitHub

  committed
  0cb6cef

• fix(ci): micro-benchmark (again)

  KSXGitHub

  committed
  0f502f9

• fix(ci): micro-benchmark (again)

  KSXGitHub

  committed
  b1ab7d0

• fix(benchmark): fixture path

  KSXGitHub

  committed
  80c6999

• fix(benchmark): fixture path

  KSXGitHub

  committed
  e9185e4

• chore(git): merge from main

  KSXGitHub

  committed
  b11de0f

• refactor: move a function

  KSXGitHub

  committed
  adbba37

• docs: an unwrap

  KSXGitHub

  committed
  ddeb577

• refactor: InstallSinglePkgToVirtualDir

  KSXGitHub

  committed
  a7494bc

• docs: InstallSinglePkgToVirtualDir

  KSXGitHub

  committed
  aeaa479

• docs: summary should be in one paragraph.

  KSXGitHub

  committed
  36a300b

• docs: unwrap

  KSXGitHub

  committed
  7e7a6af

• docs: plan

  KSXGitHub

  committed
  f009373

Commits on Oct 11, 2023

• docs: note the necessity

  KSXGitHub

  committed
  87973db

• perf(install): skip requesting index when pinned

  KSXGitHub

  committed
  3810d27

• refactor: change match to if let

  KSXGitHub

  committed
  00d49de

• refactor: remove fetch_package_version_directly

  KSXGitHub

  committed
  038abe9

• docs: remove a TODO

  KSXGitHub

  committed
  a97254d

• docs: planning

  KSXGitHub

  committed
  6f95853

• docs: change the plan

  KSXGitHub

  committed
  2b79f20

Commits on Oct 12, 2023

• feat: PackageTag

  KSXGitHub

  committed
  3d3131d

• docs: missing feature

  KSXGitHub

  committed
  419c10f

• refactor: rename some variables

  KSXGitHub

  committed
  c65e51f

• refactor: guard against error

  KSXGitHub

  committed
  35371b7

• docs: remove outdated TODO

  KSXGitHub

  committed
  240b9a1

• refactor: rename

  KSXGitHub

  committed
  2d04a8d

• refactor: stop using pkg

  KSXGitHub

  committed
  6c81425

• docs: InstallPackageBySnapshotError

  KSXGitHub

  committed
  a1110d6

• refactor: move a function

  KSXGitHub

  committed
  d4803fd

• refactor: InstallPackageFromRegistry

  KSXGitHub

  committed
  2f4a2e1

• refactor: turn internal_fetch into a method

  KSXGitHub

  committed
  d909f97

• refactor: rename a method

  KSXGitHub

  committed
  fcaa74e

• refactor: correct a field name

  KSXGitHub

  committed
  b6b1a52

• docs: InstallPackageFromRegistryError

  KSXGitHub

  committed
  c26c9e7

• docs: fields

  KSXGitHub

  committed
  26c9f40

• docs: linkify

  KSXGitHub

  committed
  21787a4

• refactor: rearrange some fields

  KSXGitHub

  committed
  8ed7199

• refactor: move a function

  KSXGitHub

  committed
  4d0f6d4

• refactor: mod should have same name

  KSXGitHub

  committed
  ae3c114

• refactor: move a function

  KSXGitHub

  committed
  e2d2965

• refactor: consistent method naming

  KSXGitHub

  committed
  cbe6b11

Commits on Oct 13, 2023

• refactor: move a code section

  KSXGitHub

  committed
  8b2bb8c

• docs: InstallFrozenLockfile

  KSXGitHub

  committed
  daecbfd

• refactor: star export

  KSXGitHub

  committed
  5bdeeb6

• refactor: destructure

  KSXGitHub

  committed
  edcf147

• refactor: InstallWithoutLockfile

  KSXGitHub

  committed
  2a2787f

• refactor(test): remove unnecessary tempdir

  KSXGitHub

  committed
  54445c6

• refactor: reuse

  KSXGitHub

  committed
  1625a23

• refactor: remove fake mut

  KSXGitHub

  committed
  e6a7268

• refactor: move code from install

  KSXGitHub

  committed
  2999bf9

• refactor(test): move

  KSXGitHub

  committed
  742a6e2

• docs: remove useless comment

  KSXGitHub

  committed
  4807700

• refactor: make add reuse install

  KSXGitHub

  committed
  7f72108

• fix(windows): missing dependencies

  KSXGitHub

  committed
  050e2b4

• refactor(test): move util functions to a crate

  KSXGitHub

  committed
  ea6207c

• style: remove some empty lines

  KSXGitHub

  committed
  d31beab

• chore: remove unused file

  KSXGitHub

  committed
  896f30d

• refactor(test): move a function to utils

  KSXGitHub

  committed
  2e1c00d

• docs: move the brief overview

  KSXGitHub

  committed
  8fcc5a9

• docs: brief overview for frozen lockfile algorithm

  KSXGitHub

  committed
  2730577

• style: merge imports

  KSXGitHub

  committed
  e8be328

• refactor: rename cli types

  KSXGitHub

  committed
  c42730d

• style: fix imports

  KSXGitHub

  committed
  764c744

• refactor: rename

  KSXGitHub

  committed
  2be4d72

• refactor: rename files

  KSXGitHub

  committed
  e5a8cef

• style: merge imports

  KSXGitHub

  committed
  4178483

• refactor: rename

  KSXGitHub

  committed
  9a88dd3

• style: shorten import line

  KSXGitHub

  committed
  75a7a85

Commits on Oct 14, 2023

• refactor: rename

  KSXGitHub

  committed
  05a7cab

• refactor: group dependency options together

  KSXGitHub

  committed
  b498a0c

• style: consistent derive order

  KSXGitHub

  committed
  2e277dd

• style: consistent derive order

  KSXGitHub

  committed
  ba691f1

• style: use clap attribute

  KSXGitHub

  committed
  c3ab708

• refactor: use iterator to list dependency groups

  KSXGitHub

  committed
  ab6fbd6

• docs: correction

  KSXGitHub

  committed
  7cc6ffb

• docs: AddDependencyOptions::dependency_groups

  KSXGitHub

  committed
  829041c

• docs(test): correct a name

  KSXGitHub

  committed
  70833b9

• test: AddDependencyOptions::dependency_groups

  KSXGitHub

  committed
  93be4aa

• refactor: derive less

  KSXGitHub

  committed
  1c8a86b

• refactor: stop using mod.rs

  KSXGitHub

  committed
  ed78c9d

• style(test): remove unnecessary pub

  KSXGitHub

  committed
  9048cce

• refactor: make dependency_groups private

  KSXGitHub

  committed
  6e75b1f

• refactor(cli): remove explicit longs

  KSXGitHub

  committed
  3efa05d

• refactor(cli): use clap attribute

  KSXGitHub

  committed
  206b705

• feat(cli): don't eagerly call current_dir

  KSXGitHub

  committed
  6e3ff87

• refactor: move some code

  KSXGitHub

  committed
  90e45a7

• refactor: move error types closer to their users

  KSXGitHub

  committed
  3604c98

• refactor: remove unused clap groups

  KSXGitHub

  committed
  436356a

• refactor: rename error variants

  KSXGitHub

  committed
  ccdea75

• feat(cli): propagate an error

  KSXGitHub

  committed
  e4fa7c4

• style: prefer use statements

  KSXGitHub

  committed
  77b64bd

• style: merge imports

  KSXGitHub

  committed
  232cae6

• chore(cargo): remove unused dependencies

  KSXGitHub

  committed
  e4d66fe

• refactor(cli): import directly

  KSXGitHub

  committed
  efc2068

• refactor: remove unused type aliases

  KSXGitHub

  committed
  58d12f9

• refactor: remove re-export of macro-only crate

  KSXGitHub

  committed
  c627b82

• refactor: use the crates directly

  KSXGitHub

  committed
  b1b0bdb

• refactor(executor): use derive_more

  KSXGitHub

  committed
  ca00e24

• feat(executor): distinct error variants

  KSXGitHub

  committed
  35b6db4

• fix: compile error

  KSXGitHub

  committed
  147ff46

• refactor(test): proper integration test

  KSXGitHub

  committed
  a9206da

• test(cli): package.json

  KSXGitHub

  committed
  24e4a8e

• test(cli): proper integration test

  KSXGitHub

  committed
  3a5c86d

• test(cli): change titles

  KSXGitHub

  committed
  ba57918

• test(cli): add missing title

  KSXGitHub

  committed
  9008979

• refactor(test): reuse code

  KSXGitHub

  committed
  caeabd2

• test(cli): proper integration test

  KSXGitHub

  committed
  c635468

• test(cli): add a title

  KSXGitHub

  committed
  ab25256

• test(cli): integration test for pacquet install

  KSXGitHub

  committed
  447b899

• test(cli): change title

  KSXGitHub

  committed
  1769c60

• test(cli): proper integration test

  KSXGitHub

  committed
  db05100

• test(cli): proper integration test

  KSXGitHub

  committed
  1f7fdcc

• refactor(cli): rename cli_command to cli_args

  KSXGitHub

  committed
  98ba757

• feat(cli): only load .npmrc when necessary

  KSXGitHub

  committed
  8be20ea

• fix(test): forgot to set current_dir

  KSXGitHub

  committed
  e15900c

• test(cli): init

  KSXGitHub

  committed
  7824b31

• refactor(test): share code

  KSXGitHub

  committed
  086af30

• test(cli): remove nonsensical test

  KSXGitHub

  committed
  58de7e0

• test(cli): pacquet store path

  KSXGitHub

  committed
  73f6c08

• refactor(test): remove mut

  KSXGitHub

  committed
  0a2fd52

• refactor(test): remove unnecessary action

  KSXGitHub

  committed
  15a8946

• refactor(cli): attach code to respective args

  KSXGitHub

  committed
  cabff79

• refactor(cli): remove methods from PackageManager

  KSXGitHub

  committed
  e1ee4eb

• refactor: rename PackageManager to State

  KSXGitHub

  committed
  3dd9794

• refactor: use

  KSXGitHub

  committed
  1d183db

• feat(npmrc): PackageJson::path

  KSXGitHub

  committed
  6d4df48

• feat(npmrc): lifetime

  KSXGitHub

  committed
  7dbf11a

• refactor(cli): pass the state

  KSXGitHub

  committed
  5189c82

• refactor(npmrc): dependency injection

  KSXGitHub

  committed
  509c368

• docs: what's wrong

  KSXGitHub

  committed
  45e802c

• fix(npmrc): the algorithm

  Show description for ce0369a
  KSXGitHub

  committed
  ce0369a

Commits on Oct 15, 2023

• style: move error type closer to its user

  KSXGitHub

  committed
  636229b

• refactor: use derive_more

  KSXGitHub

  committed
  fce5673

• refactor(cli): lazy package_json_path

  KSXGitHub

  committed
  1b1a760

• refactor: be explicit

  KSXGitHub

  committed
  ce93200

• refactor: destroy args on use

  KSXGitHub

  committed
  28d3695

• refactor: remove early return

  KSXGitHub

  committed
  0a91d1e

• refactor(cli): attach code to args

  KSXGitHub

  committed
  206a8b7

• docs(cli): State

  KSXGitHub

  committed
  f89a5f9

• docs: fields of State

  KSXGitHub

  committed
  d5dc166

• style: rearrange the fields

  KSXGitHub

  committed
  bc73b25

• refactor: convert a function to a struct

  KSXGitHub

  committed
  3e6e49b

• docs: DownloadTarballToStore

  KSXGitHub

  committed
  02ee0b2

• refactor: name error by step it happens

  KSXGitHub

  committed
  d48d908

• refactor: use derive_more

  KSXGitHub

  committed
  1cb3822

• fix(test): macOS on CI

  KSXGitHub

  committed
  246b488

• chore(cargo): use [email protected]

  KSXGitHub

  committed
  c25d9c8

• fix(test): windows

  KSXGitHub

  committed
  8d80da3

• chore: remove accidental file

  KSXGitHub

  committed
  05870a3

• chore(cargo): remove unused dependency

  KSXGitHub

  committed
  5088dac

• fix(test): windows, again

  KSXGitHub

  committed
  1a0d2c8

• chore(cargo): remove unused dependency

  KSXGitHub

  committed
  9b17091

• refactor: replace thiserror with derive_more

  Show description for ca110d9
  KSXGitHub

  committed
  ca110d9

• fix(test): windows, macos

  KSXGitHub

  committed
  4025766

Commits on Oct 16, 2023

• refactor: use getters

  KSXGitHub

  committed
  11924f4

• refactor: remove unnecessary pub

  KSXGitHub

  committed
  11dfe1b

• refactor: remove unnecessary pub

  KSXGitHub

  committed
  0ad43b2

• refactor: rename DependencyGroup::{Default -> Prod}

  KSXGitHub

  committed
  886f1d4

• docs: future plan

  KSXGitHub

  committed
  1aee2a3

• docs: list_dependency_groups

  KSXGitHub

  committed
  ea79141

• docs: why it is that way it is

  KSXGitHub

  committed
  e877d1d

• docs: future plan

  KSXGitHub

  committed
  86b52d9

• refactor: rename PackageJson to PackageManifest

  KSXGitHub

  committed
  5f953bb

• docs: PackageManifest

  KSXGitHub

  committed
  de034f9

• refactor: rename fields and variables

  KSXGitHub

  committed
  a04e42e

• style: cargo fmt

  KSXGitHub

  committed
  601a90f

• refactor: rename more

  KSXGitHub

  committed
  a38bb0b

• style: consistent crate dir name

  KSXGitHub

  committed
  3fc1938

• refactor: use kebab-case where possible

  Show description for 075e788
  KSXGitHub

  committed
  075e788

• fix(ci): check all docs

  KSXGitHub

  committed
  c6e1a77

• fix(ci): micro-benchmark

  KSXGitHub

  committed
  9f6204f

• docs: remove redundant comment

  KSXGitHub

  committed
  c25d2b3

• refactor: rename package to package_name

  KSXGitHub

  committed
  400eb55

• docs: future plan

  KSXGitHub

  committed
  bc9a454

• docs: remove from fields

  KSXGitHub

  committed
  7ba09df

• chore(git): merge from main

  KSXGitHub

  committed
  f6f5c40

• fix(clippy): windows

  KSXGitHub

  committed
  78c4e1c

• docs(cli): remove a "pacquet" mention

  Show description for 4e8463b
  

  KSXGitHub

  and

  zkochan

  authored
  4e8463b

• docs: future plan

  KSXGitHub

  committed
  5a7ed67

• chore(git): pull

  KSXGitHub

  committed
  c82a2a7

Commits on Oct 17, 2023

• chore(git): merge from main

  KSXGitHub

  committed
  8ea5089

Commits on Oct 21, 2023

• chore(git): merge from main

  KSXGitHub

  committed
  47b3fa0