Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

slab metrics unit test: test_metrics_evict_refcount #42

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

slab metrics unit test: test_metrics_evict_refcount #42

wants to merge 1 commit into from

Conversation

TomekIdczak97
Copy link

@TomekIdczak97 TomekIdczak97 commented Jul 17, 2019 •
edited by michalbiesek
Loading

Simple slab metrics unit test for pmem: test_metrics_evict_refcount

This change is Reviewable

@michalbiesek
Copy link

Please add information about stats which are not equal.

@TomekIdczak97
Copy link
Author

Please add information about stats which are not equal.

Assertion 'm1_buf == m2_buf' failed: m1_buf == "STATS item_curr 1", m2_buf == "STATS item_curr 0"

@michalbiesek
Copy link

@jschmieg FYI

The first check for statistics is in my opinion actually true.
You only reserve item there wasn't any insert operation yet - so the item isn't linked yet - after recreating items there are no way to distinguish this situation that item was only reserved

Second check for stats fails regarding slab request - I am not sure if this test is even correct.
I mean after teardown it should be NULLed

This was referenced Jul 17, 2019
Merged
Open
@TomekIdczak97
Copy link
Author

Failure - assertion message:
Saved:

STATS item_curr 1
STATS item_alloc 1

After restart:

STATS item_curr 0
STATS item_alloc 0

@TomekIdczak97 TomekIdczak97 force-pushed the test_metrics_evict_refcount branch 3 times, most recently from 66cdc82 to a22d79c Compare August 12, 2019 06:42
@TomekIdczak97 TomekIdczak97 force-pushed the test_metrics_evict_refcount branch 5 times, most recently from be4402f to 36921c4 Compare August 20, 2019 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TomekIdczak97 @michalbiesek