Reset item in case of reserve #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michalbiesek
force-pushed
the
slab-reserve
branch
from
0d15806
to
ae2e9f2
Compare
michalbiesek
force-pushed
the
slab-reserve
branch
from
ae2e9f2
to
3a5ce20
Compare
|
A situation when item X is reserved and item X+1 (next one) is linked will cause item X leak after startup because next_item_in_slab pointer will skip reserved item X. |
michalbiesek
force-pushed
the
slab-reserve
branch
2 times, most recently
from
8ee2afb
to
13b1714
Compare
|
@jschmieg please look for this now |
michalbiesek
force-pushed
the
slab-reserve
branch
2 times, most recently
from
7fbce6f
to
c518b2d
Compare
jschmieg
reviewed
Aug 22, 2019
src/storage/slab/slab.c
Outdated
| @@ -189,6 +189,9 @@ _slab_recreate_items(struct slab *slab) | |||
| } | |||
| } else if (it->in_freeq) { | |||
| _slab_put_item_into_freeq(it, slab->id); | |||
| } else if ((it->klen ) && (it->vlen == 0)) { | |||
There was a problem hiding this comment.
I remove brackets to be inline with rest of the code
jschmieg
approved these changes
Aug 22, 2019
added 2 commits
August 22, 2019 14:00
- in case of reserve item and restart db item would be release
- test_evict_refcount remove one reset where reserved item is deleted
michalbiesek
force-pushed
the
slab-reserve
branch
from
c518b2d
to
9a46536
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
partial request
Ref: #42 (comment)
This change is