-
-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix invalid values in RelationListFieldSerializer. #1818
Conversation
@Faakhir30 thanks for creating this Pull Request and helping to improve Plone! TL;DR: Finish pushing changes, pass all other checks, then paste a comment:
To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically. Happy hacking! |
I think it would be interesting to do a test for this here:
You can use the
|
@jenkins-plone-org please run jobs |
@jenkins-plone-org please run jobs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@jenkins-plone-org please run jobs |
7de6017
to
8c67abe
Compare
@jenkins-plone-org please run jobs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. We can merge it once the builds are green.
Closes #1745
Filtered
NoneType
items from the resulting list atRelationListFieldSerializer
.I guess we don't need to update this also in
RelationChoiceFieldSerializer
, as it is returning a singleRelationValue
orNone
value, so it should be fine this way.📚 Documentation preview 📚: https://plonerestapi--1818.org.readthedocs.build/