use to_id attribute to check content's existance.

plone · Oct 2, 2024 · 8c67abe · 8c67abe
1 parent f87a86b
commit 8c67abe
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 6 deletions.
diff --git a/src/plone/restapi/serializer/relationfield.py b/src/plone/restapi/serializer/relationfield.py
@@ -42,9 +42,7 @@ def get_value(self, default=[]):
         Returns:
             list: List of RelationValues
         """
-        value = getattr(
-            self.field.interface(self.context), self.field.__name__, default
-        )
+        value = super().get_value()
         if not value:
             return []
-        return [el for el in value if el.to_object]
+        return [el for el in value if el.to_id]
diff --git a/src/plone/restapi/tests/test_dxcontent_serializer.py b/src/plone/restapi/tests/test_dxcontent_serializer.py
@@ -28,6 +28,7 @@
 from zope.component import queryUtility
 from zope.interface import Interface
 from z3c.relationfield import RelationValue
+from z3c.relationfield.event import _setRelation
 from zope.component import getUtility
 from zope.intid.interfaces import IIntIds
 from zope.publisher.interfaces.browser import IBrowserRequest
@@ -201,10 +202,14 @@ def test_serializer_excludes_deleted_relations(self):
             "DXTestDocument",
             id="doc2",
         )
+        rel1 = RelationValue(intids.getId(self.portal.doc1))
+        rel2 = RelationValue(intids.getId(self.portal.doc2))
         self.portal.doc1.test_relationlist_field = [
-            RelationValue(intids.getId(self.portal.doc1)),
-            RelationValue(intids.getId(self.portal.doc2)),
+            rel1,
+            rel2,
         ]
+        _setRelation(self.portal.doc1, "test_relationlist_field", rel1)
+        _setRelation(self.portal.doc1, "test_relationlist_field", rel2)
         # delete doc2 to make sure we have a None value in the relation list
         self.portal.manage_delObjects(["doc2"])