Skip to content

Commit

Permalink
updated go version to 1.23
Browse files Browse the repository at this point in the history
  • Loading branch information
Deepak Chauhan authored and Deepak Chauhan committed Nov 25, 2024
1 parent 825f0ff commit 914f34b
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 6 deletions.
4 changes: 2 additions & 2 deletions Dockerfile
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# Build the manager binary
FROM golang:1.21 as builder
FROM golang:1.23 as builder

WORKDIR /workspace
# Copy the Go Modules manifests
Expand All @@ -23,7 +23,7 @@ RUN CGO_ENABLED=0 GOOS=linux GOARCH=amd64 go build -a -o manager main.go
# Refer to https://github.com/GoogleContainerTools/distroless for more details
#FROM gcr.io/distroless/static:nonroot

FROM alpine:3.18
FROM alpine:3.20
RUN apk add --no-cache bash
WORKDIR /
COPY --from=builder /workspace/manager .
Expand Down
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,7 @@ $(ENVTEST): $(LOCALBIN)
GOBIN=$(LOCALBIN) go install sigs.k8s.io/controller-runtime/tools/[email protected]

img-test:
docker run --rm -v $(SRCROOT):/luigi -w /luigi golang:1.21 bash -c "GOFLAGS=-buildvcs=false make test"
docker run --rm -v $(SRCROOT):/luigi -w /luigi golang:1.23 bash -c "GOFLAGS=-buildvcs=false make test"

img-build: $(BUILD_DIR) img-test
docker build --network host . -t ${IMG}
Expand Down
4 changes: 2 additions & 2 deletions config/crd/bases/plumber.k8s.pf9.io_networkplugins.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -56,10 +56,10 @@ spec:
type: string
imagePullPolicy:
type: string
namespace:
type: string
metricsPort:
type: string
namespace:
type: string
type: object
multus:
properties:
Expand Down
1 change: 0 additions & 1 deletion controllers/networkplugins_controller.go
Original file line number Diff line number Diff line change
Expand Up @@ -959,4 +959,3 @@ func GetHugepageSize() string {
fmt.Printf("Hugepages: %+v", r)
return r
}

0 comments on commit 914f34b

Please sign in to comment.