[FlexFec] Adding support for FlexFec RFC-03 #644
pougetatlint.yaml
on: pull_request
lint
/
Metadata
12s
lint
/
Go
36s
Annotations
9 errors and 11 warnings
|
Invalid Go version:
go.mod#L3
Found 1.15. Expected 1.19
|
|
lint / Go:
pkg/flexfec/encoder_interceptor.go#L74
Error return value of `writer.Write` is not checked (errcheck)
|
|
lint / Go:
pkg/flexfec/flexfec_coverage.go#L132
assignOp: replace `mask2 = mask2 >> 34` with `mask2 >>= 34` (gocritic)
|
|
lint / Go:
pkg/flexfec/flexfec_coverage.go#L127
commentFormatting: put a space between `//` and comment text (gocritic)
|
|
lint / Go:
pkg/flexfec/flexfec_coverage.go#L139
commentFormatting: put a space between `//` and comment text (gocritic)
|
|
lint / Go:
pkg/flexfec/flexfec_coverage.go#L145
commentFormatting: put a space between `//` and comment text (gocritic)
|
|
lint / Go:
pkg/flexfec/encoder_interceptor.go#L21
field `opts` is unused (unused)
|
|
lint / Go:
pkg/flexfec/encoder_interceptor.go#L26
S1008: should use 'return info.MimeType == "video/VP8"' instead of 'if info.MimeType == "video/VP8" { return true }; return false' (gosimple)
|
|
lint / Go
issues found
|
|
lint / Metadata
Restore cache failed: Dependencies file is not found in /home/runner/work/interceptor/interceptor. Supported file pattern: go.sum
|
|
lint / Go:
pkg/flexfec/util/bitarray.go#L36
indent-error-flow: if block ends with a return statement, so drop this else and outdent its block (revive)
|
|
lint / Go:
pkg/flexfec/util/bitarray.go#L23
exported: exported method BitArray.Reset should have comment or be unexported (revive)
|
|
lint / Go:
pkg/flexfec/flexfec_encoder_03.go#L16
exported: comment on exported const BaseFec03HeaderSize should be of the form "BaseFec03HeaderSize ..." (revive)
|
|
lint / Go:
pkg/flexfec/flexfec_encoder_03.go#L21
exported: comment on exported type FlexEncoder03 should be of the form "FlexEncoder03 ..." (with optional leading article) (revive)
|
|
lint / Go:
pkg/flexfec/flexfec_encoder_03.go#L29
exported: comment on exported function NewFlexEncoder03 should be of the form "NewFlexEncoder03 ..." (revive)
|
|
lint / Go:
pkg/flexfec/encoder_interceptor.go#L11
exported: exported type FecInterceptor should have comment or be unexported (revive)
|
|
lint / Go:
pkg/flexfec/flexfec_coverage.go#L59
exported: exported method ProtectionCoverage.UpdateCoverage should have comment or be unexported (revive)
|
|
lint / Go:
pkg/flexfec/flexfec_encoder.go#L23
exported: exported type FlexEncoder should have comment or be unexported (revive)
|
|
lint / Go:
pkg/flexfec/encoder_interceptor.go#L18
exported: exported type FECEncoderOption should have comment or be unexported (revive)
|
|
lint / Go:
pkg/flexfec/flexfec_encoder_03.go#L183
indent-error-flow: if block ends with a return statement, so drop this else and outdent its block (revive)
|