-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FlexFec] Adding support for FlexFec RFC-03 #214
Conversation
pkg/flexfec/encoder_interceptor.go
Outdated
if info.MimeType == "video/VP8" { | ||
return true | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should support more than just VP8.
Codecov ReportAll modified and coverable lines are covered by tests ✅ see 12 files with indirect coverage changes 📢 Thoughts on this report? Let us know!. |
|
||
interceptor := &FecInterceptor{ | ||
packetBuffer: make([]rtp.Packet, 0), | ||
minNumMediaPackets: 5, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be configurable
20356a3
to
531ec04
Compare
531ec04
to
e4d7e64
Compare
Hey @pougetat, does this only work for Opus (since it has
I'm assuming that means that flexfec-03 has to be sent over 49 instead of something like 96 or am I misunderstanding something? Is this interceptor plug and play or do I need to set up extra lines in the SDP/RTCPFeedback/etc? |
Description
Context
This PR is part of a series of PRs to provide FlexFec support for pion.
https://datatracker.ietf.org/doc/html/rfc8627
Summary
This PR provides the following:
There are still some issues to be tackled:
Reference issue
Fixes #...