Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in reporting upper ccsinje bound for DEU in NPis #654

Merged
merged 2 commits into from
Sep 16, 2024

Conversation

tabeado
Copy link
Contributor

@tabeado tabeado commented Sep 16, 2024

INF was reported for the maximum available carbon storage for DEU in NPis due to lack of specification of the technology and grade.

This PR solves this issue: #561

Copy link
Contributor

@orichters orichters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks good, but please run make build / lucode2::buildLibrary() to check whether this creates any issues with the test gdx files.

@orichters
Copy link
Contributor

The check somehow failed, but that seems to be a random github error. I restarted the check, in case that doesn't fix it, feel free to merge anyway.

@tabeado
Copy link
Contributor Author

tabeado commented Sep 16, 2024

Many thanks Oli for the quick review & restarting the check!

@tabeado tabeado merged commit 1e4ff83 into pik-piam:master Sep 16, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants