Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Infinite CCS potential for DEU reported #561

Closed
0UmfHxcvx5J7JoaOhFSs5mncnisTJJ6q opened this issue Mar 11, 2024 · 9 comments
Closed

Infinite CCS potential for DEU reported #561

0UmfHxcvx5J7JoaOhFSs5mncnisTJJ6q opened this issue Mar 11, 2024 · 9 comments
Assignees
@tabeado
Labels
bug Something isn't working

Comments

@0UmfHxcvx5J7JoaOhFSs5mncnisTJJ6q
Copy link
Member

This

remind2/R/reportEmi.R

Lines 1634 to 1635 in ee372c4

setNames(dimSums(max_geolStorage, dim = 3, na.rm = T) * GtC_2_MtCO2,
"Carbon Management|Storage|Maximum annual CO2 storage potential (Mt CO2/yr)")

does not work for DEU (and by extension EUR, EU27, and World). For an example see /p/projects/remind/modeltests/remind/output/SSP2EU-EU21-NPi-AMT_2024-03-01_22.12.41/REMIND_generic_SSP2EU-EU21-NPi-AMT_withoutPlus.mif

$ sed -n '1 p; /Carbon Management|Storage|Maximum annual CO2 storage potential/ p' /p/projects/remind/modeltests/remind/output/SSP2EU-EU21-NPi-AMT_2024-03-01_22.12.41/REMIND_generic_SSP2EU-EU21-NPi-AMT_withoutPlus.mi
f | cut -d ';' -f -12 | column -ts ';'
Model   Scenario             Region  Variable                                                        Unit       2005  2010  2015  2020        2025        2030          2035
REMIND  SSP2EU-EU21-NPi-AMT  CAZ     Carbon Management|Storage|Maximum annual CO2 storage potential  Mt CO2/yr  0     0     0     18.4999833  18.4999833  1515.6069293  1515.6069293
REMIND  SSP2EU-EU21-NPi-AMT  CHA     Carbon Management|Storage|Maximum annual CO2 storage potential  Mt CO2/yr  0     0     0     9.4099867   9.4099867   1837.0965745  1837.0965745
REMIND  SSP2EU-EU21-NPi-AMT  DEU     Carbon Management|Storage|Maximum annual CO2 storage potential  Mt CO2/yr  Inf   Inf   Inf   Inf         Inf         Inf           110
REMIND  SSP2EU-EU21-NPi-AMT  ECE     Carbon Management|Storage|Maximum annual CO2 storage potential  Mt CO2/yr  0     0     0     0           0           29.75         29.75
REMIND  SSP2EU-EU21-NPi-AMT  ECS     Carbon Management|Storage|Maximum annual CO2 storage potential  Mt CO2/yr  0     0     0     0           0           73.645        73.645
REMIND  SSP2EU-EU21-NPi-AMT  ENC     Carbon Management|Storage|Maximum annual CO2 storage potential  Mt CO2/yr  0     0     0     0           0           55            55
REMIND  SSP2EU-EU21-NPi-AMT  ESC     Carbon Management|Storage|Maximum annual CO2 storage potential  Mt CO2/yr  0     0     0     0           0           34.0199999    34.0199999
REMIND  SSP2EU-EU21-NPi-AMT  ESW     Carbon Management|Storage|Maximum annual CO2 storage potential  Mt CO2/yr  0     0     0     0           0           70.895        70.895
REMIND  SSP2EU-EU21-NPi-AMT  EU27    Carbon Management|Storage|Maximum annual CO2 storage potential  Mt CO2/yr  Inf   Inf   Inf   Inf         Inf         Inf           556.6433332
REMIND  SSP2EU-EU21-NPi-AMT  EUR     Carbon Management|Storage|Maximum annual CO2 storage potential  Mt CO2/yr  Inf   Inf   Inf   Inf         Inf         Inf           739.9766666
REMIND  SSP2EU-EU21-NPi-AMT  EWN     Carbon Management|Storage|Maximum annual CO2 storage potential  Mt CO2/yr  0     0     0     0           0           91.6666667    91.6666667
REMIND  SSP2EU-EU21-NPi-AMT  FRA     Carbon Management|Storage|Maximum annual CO2 storage potential  Mt CO2/yr  0     0     0     0           0           91.6666667    91.6666667
REMIND  SSP2EU-EU21-NPi-AMT  IND     Carbon Management|Storage|Maximum annual CO2 storage potential  Mt CO2/yr  0     0     0     0           0           916.6666667   916.6666667
REMIND  SSP2EU-EU21-NPi-AMT  JPN     Carbon Management|Storage|Maximum annual CO2 storage potential  Mt CO2/yr  0     0     0     0           0           343.75        343.75
REMIND  SSP2EU-EU21-NPi-AMT  LAM     Carbon Management|Storage|Maximum annual CO2 storage potential  Mt CO2/yr  0     0     0     1.00001     1.00001     2752.1713186  2752.1713186
REMIND  SSP2EU-EU21-NPi-AMT  MEA     Carbon Management|Storage|Maximum annual CO2 storage potential  Mt CO2/yr  0     0     0     1.5999867   1.5999867   1763.4501751  1763.4501751
REMIND  SSP2EU-EU21-NPi-AMT  NEN     Carbon Management|Storage|Maximum annual CO2 storage potential  Mt CO2/yr  0     0     0     2.9000033   2.9000033   128.3333333   128.3333333
REMIND  SSP2EU-EU21-NPi-AMT  NES     Carbon Management|Storage|Maximum annual CO2 storage potential  Mt CO2/yr  0     0     0     0           0           3.59          3.59
REMIND  SSP2EU-EU21-NPi-AMT  NEU     Carbon Management|Storage|Maximum annual CO2 storage potential  Mt CO2/yr  0     0     0     2.9000033   2.9000033   131.9233333   131.9233333
REMIND  SSP2EU-EU21-NPi-AMT  OAS     Carbon Management|Storage|Maximum annual CO2 storage potential  Mt CO2/yr  0     0     0     1.9999833   1.9999833   912.9034255   912.9034255
REMIND  SSP2EU-EU21-NPi-AMT  REF     Carbon Management|Storage|Maximum annual CO2 storage potential  Mt CO2/yr  0     0     0     0           0           5280.3695241  5280.3695241
REMIND  SSP2EU-EU21-NPi-AMT  SSA     Carbon Management|Storage|Maximum annual CO2 storage potential  Mt CO2/yr  0     0     0     0           0           1160.8644197  1160.8644197
REMIND  SSP2EU-EU21-NPi-AMT  UKI     Carbon Management|Storage|Maximum annual CO2 storage potential  Mt CO2/yr  0     0     0     3.7999867   3.7999867   183.3333333   183.3333333
REMIND  SSP2EU-EU21-NPi-AMT  USA     Carbon Management|Storage|Maximum annual CO2 storage potential  Mt CO2/yr  0     0     0     28.1000133  28.1000133  2289.4953481  2289.4953481
REMIND  SSP2EU-EU21-NPi-AMT  World   Carbon Management|Storage|Maximum annual CO2 storage potential  Mt CO2/yr  Inf   Inf   Inf   Inf         Inf         Inf           19644.2743814

For some reason, vm_co2ccs.up(DEU,pcc) and vm_co2ccs.up(DEU,pco) are Inf, which of course sums up to Inf. Either figure out why that is on the REMIND/GAMS side, or here

max_geolStorage[is.infinite(max_geolStorage)] <- NA
@0UmfHxcvx5J7JoaOhFSs5mncnisTJJ6q 0UmfHxcvx5J7JoaOhFSs5mncnisTJJ6q added the bug Something isn't working label Mar 11, 2024
@tabeado
Copy link
Contributor

tabeado commented Mar 14, 2024 •
edited
Loading

@orichters pointed towards these lines (thank you!):
https://github.com/remindmodel/remind/blob/854dfea96f49906db764b6b1f3dcf7e3fdf59c06/modules/47_regipol/none/bounds.gms#L24
https://github.com/remindmodel/remind/blob/854dfea96f49906db764b6b1f3dcf7e3fdf59c06/modules/47_regipol/regiCarbonPrice/bounds.gms#L54

@amerfort and @fschreyer: Is this line still required given the update of the near-term CCS bounds? I believe the DEU limit is no longer envisioned to be 0 in 2030? If this should still be an option for different scenarios, we might want to change it to a switch?

@fschreyer
Copy link
Contributor

If Germany is covered by the new CCS bounds, which I think is the case, this can be removed.

@orichters
Copy link
Contributor

@tabeado Can we fix that before the release, probably just removing those two lines?

@tabeado
Copy link
Contributor

tabeado commented Apr 15, 2024

Summary of a brief discussion with Felix:

  • The original DEU upper bound for 2030 was ~3MtCO2/yr, after Anne's update it is up to 32MtCO2/yr. This should be discussed again in the context of continuity in the Ariadne project. It might be helpful to know how relevant the change of the upper bound is, given the high adjustment cost + also increased ccsinje cost. @amerfort do you have any runs for that already?
  • The current setting, changing the consistent input data logic just for DEU in the module is not transparent. Thus would likely need some change if the original value was chosen to be kept.

Felix takes it to the REMIND-EU meeting to make a decision.

@0UmfHxcvx5J7JoaOhFSs5mncnisTJJ6q
Copy link
Member Author

Felix takes it to the REMIND-EU meeting to make a decision.

Was any decision made?

SSP2-EU21-NPi-AMT_2024-08-16_22.12.58/REMIND_generic_SSP2-EU21-NPi-AMT_withoutPlus.mif

Model   Scenario           Region  Variable                                                        Unit       2005  2010  2015  2020  2025  2030
REMIND  SSP2-EU21-NPi-AMT  DEU     Carbon Management|Storage|Maximum annual CO2 storage potential  Mt CO2/yr  Inf   Inf   Inf   Inf   Inf   Inf
REMIND  SSP2-EU21-NPi-AMT  EU27    Carbon Management|Storage|Maximum annual CO2 storage potential  Mt CO2/yr  Inf   Inf   Inf   Inf   Inf   Inf
REMIND  SSP2-EU21-NPi-AMT  EUR     Carbon Management|Storage|Maximum annual CO2 storage potential  Mt CO2/yr  Inf   Inf   Inf   Inf   Inf   Inf
REMIND  SSP2-EU21-NPi-AMT  World   Carbon Management|Storage|Maximum annual CO2 storage potential  Mt CO2/yr  Inf   Inf   Inf   Inf   Inf   Inf

@fschreyer
Copy link
Contributor

I don't see how it relates to this line. The run you show does not have it anymore.

Shouldn't summing over all elements of an upper bounds always give INF because this is what an upper bound is by default? Without looking deeper, I don't quite get why it only occurs for Germany. I would say that we should just assign elements of cco2.ico2.ccsinje.1 in this line as this is what is used as CCS potential and that should do it.

@orichters
Copy link
Contributor

In core/bounds.gms, we have

vm_co2CCS.up(t,regi,"cco2","ico2","ccsinje","1")

In modules/47_regipol/none/bounds.gms and earlier in regipol, the assignment was

vm_co2CCS.up(t,regi,"cco2","ico2",te,rlf)

This added values to many more te and rlf instead of just ccsinje and 1, and then this sum resulted in Inf. I agree, just use ccsinje.1 in reportEmi. I would still remove the line in modules/47_regipol/none/bounds.gms as well.

@tabeado
Copy link
Contributor

tabeado commented Aug 23, 2024

Hi, thanks for picking this up again, I somehow had thought it was solved.
Unfortunately I can make the adjustment only after I return from my vacation in 2 weeks. If you want it fixed before that, please go ahead.

@tabeado tabeado mentioned this issue Sep 16, 2024
Merged
@tabeado
Copy link
Contributor

tabeado commented Sep 16, 2024

Thanks for figuring out the bug, Felix and Oli! It only occurred for NPis.

I changed the reportEmi in this PR: #654

When accepted, I think we can close this issue.

@tabeado tabeado closed this as completed Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tabeado tabeado

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@fschreyer @0UmfHxcvx5J7JoaOhFSs5mncnisTJJ6q @orichters @tabeado