Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add extra languages to translations #184

Open
dantownsend opened this issue Jul 22, 2022 · 4 comments
Open

Add extra languages to translations #184

dantownsend opened this issue Jul 22, 2022 · 4 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@dantownsend
Copy link
Member

dantownsend commented Jul 22, 2022

We recently add translation support to Piccolo Admin.

We'd love to add support for more languages. To do so, simply copy and modify one of the existing languages:

https://github.com/piccolo-orm/piccolo_admin/blob/master/piccolo_admin/translations/data.py

For example:

MY_LANGUAGE = Translation(
    language_name="My Language",
    language_code="xx",
    translations={
        "About": "XXX",
        ...
    }
)
@dantownsend dantownsend added enhancement New feature or request good first issue Good for newcomers labels Jul 22, 2022
@Saeed-Paris
Copy link

hi i can add persian language and cuz its rtl i can make styles trl too.(if u want)

@dantownsend
Copy link
Member Author

@Saeed-Paris That would be great, thanks!

I don't have much experience with RTL languages - I don't know how difficult it will be to implement.

@LeMeteore
Copy link
Contributor

I would like to respectfully improve one or two things in the french translations:

- "Add Row": "Ajouter une ligne" instead of "Ajouter une rangée"

- "Add": "Ajouter" instead of "Additionner"

- "Ascending": "Croissant" instead of "Ascendant"

- "Clear filters": "Effacer tous les filtres" instead of "Filtres à claire"

- "Close": "Fermer" instead of "proche"

- "Descending": "Décroissant" instead of "Descendant"

- "Forms": "Formulaires" instead of "Formes"

- "Home": "Accueil" instead of "Maison"

@dantownsend
Copy link
Member Author

@LeMeteore Yes, please do! The French translations were machine translated, so not the best.

dantownsend pushed a commit that referenced this issue Aug 29, 2022
* Improve french translations. Refs #184

* Improve translations, add missing parenthesis. Refs #184
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants