Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finnish translations #185

Merged

Conversation

olliglorioso
Copy link
Contributor

Finnish translations, issue #184.

@codecov-commenter
Copy link

codecov-commenter commented Jul 23, 2022

Codecov Report

Merging #185 (18feba3) into master (6797d11) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #185      +/-   ##
==========================================
+ Coverage   96.01%   96.03%   +0.01%     
==========================================
  Files           5        5              
  Lines         251      252       +1     
==========================================
+ Hits          241      242       +1     
  Misses         10       10              
Impacted Files Coverage Δ
piccolo_admin/translations/data.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us.

@dantownsend
Copy link
Member

@olliglorioso This is great, thanks!

I noticed that "Select a table in the sidebar to get started.", and "Show referencing tables" don't have translations - I presume it's because these phrases are untranslatable.

@olliglorioso
Copy link
Contributor Author

olliglorioso commented Jul 23, 2022

Hi! Oops, that's my mistake. Fixed. @dantownsend

@dantownsend
Copy link
Member

@olliglorioso Perfect, thanks!

@dantownsend dantownsend merged commit f84d6ee into piccolo-orm:master Jul 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants