-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up Regnum phylorefs #89
base: master
Are you sure you want to change the base?
Conversation
This is the number used by the Gene Ontology, Uberon and other ontologies.
Since the plan is for them to have these terms in the Clade Ontology.
This is the same as used by CDAO. Also made this into a command line argument.
This unencrypts it.
99b5364
to
8e18aff
Compare
Well, it sounds like there are two types of changes wrapped into one. By two types I mean a set of changes that does not lend itself to code review, and those that do. The overwhelming bulk (by "lines changed") seems to fall into the former category, suggesting that there is a small enough set in the latter category to still enable review. As it is, this PR is unreviewable, so if we keep it we shouldn't pretend it was ever reviewed. It sounds to me though that the changes that don't stand to benefit from review (decrypting files, for example) can be separated out, even if they would necessarily have to be accompanied by some code changes (in the tests) too. But there seem to be additional code changes (items 2, 3, and 6 in your list) that are separable changes of code that seem reviewable and would benefit from having been reviewed. |
This PR cleans up Regnum phylorefs in several ways:
REGNUM_*
toCLADO_*
and increased the number of digits to seven.encrypted/
directory so that they will no longer be encrypted.The tests are in no way fully implemented or comprehensive yet, but are sophisticated enough to note which phyloreferences include phylogenies.
Hilmar: this is a huge PR, but I don't think it makes sense to make it smaller -- it includes a bunch of changes on the encrypted files, followed by the de-encryption of the files, followed by tweaking the tests so they would pass. I could split this into two or three PRs, but if so, the first PR would just end with a bunch of encrypted files :). So I think this is better. Let me know if you disagree!