Added Brochu 2003 to the ontology of phyloreferences #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaurav
force-pushed
the
example_brochu_2003
branch
from
4e62d28
to
5d69705
Compare
gaurav
force-pushed
the
example_brochu_2003
branch
from
a6bde06
to
26fae74
Compare
|
@gaurav can you say what's left or missing here? I've lost track and it's now two weeks old. |
…' from previously curated files
…tology; added the necessary type declarations to the JSON-LD file manually
gaurav
force-pushed
the
example_brochu_2003
branch
from
0ada153
to
321ac89
Compare
…atus in test output.
…odes are resolved.
…lorefs and statuses for all phylorefs
…ogy into example_brochu_2003: updated jphyloref.jar and modified testcase2owl.py to include node labels in output.
hlapp
approved these changes
Jun 12, 2018
gaurav
added a commit
to phyloref/jphyloref
that referenced
this pull request
Jun 20, 2018
The current version of the phyloreference testing code had evolved through several different cycles, was badly written, and appeared to not be correctly testing phyloreferences using the expected_phyloreference_named property. I replaced it with cleaner, easier to read code that appears to be testing phyloreferences correctly, and tested these in PR #9 and its use in phyloref/clade-ontology#29.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds the publication Brochu 2003 as curated by the Curation Tool and incorporates it into the Ontology of Phyloreferences.
Bugs that have been fixed in this pull request are:
@context(d7c5afd) andpso:holdsStatusInTime(948376e)labelsterm to PHYX file to represent sets of labels (a56524b)It also incorporates JPhyloref improvements (phyloref/jphyloref#6, phyloref/jphyloref#9) that implements statuses for phyloreferences (phyloref/klados#25).
Some revealed have been filed to work on later, and are not resolved in this pull request:
This has now been tested in Travis and is ready for review and to be merged.