feat: add ptype parameter to artisan commands #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@leeqvip plz review |
leeqvip
requested changes
May 23, 2024
README.md
Outdated
| @@ -334,9 +334,11 @@ php artisan policy:add writer,articles,edit | |||
| Adds a role for a user: | |||
|
|
|||
| ```bash | |||
| php artisan role:assign eve writer | |||
| php artisan role:assign eve writer --type=g2 | |||
There was a problem hiding this comment.
Please use ptype instead of type to ensure consistency with the code.
--ptype is not required, so two usages should be retained.
tests/Commands/RoleAssignTest.php
Outdated
| $this->assertFalse(0 === $exitCode); | ||
| $this->assertTrue(Enforcer::hasRoleForUser('eve', 'writer')); | ||
| $this->assertTrue(Enforcer::hasNamedGroupingPolicy('g', 'eve', 'writer')); |
There was a problem hiding this comment.
Please keep the default test cases and add new test cases specifying ptype
Dobmod
changed the title
|
@leeqvip Sorry, due to my lack of proficiency, I caused a lot of trouble. I have corrected it this time.plz review |
leeqvip
approved these changes
May 24, 2024
|
🎉 This PR is included in version 3.2.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.