feat: add ptype parameter to artisan commands

php-casbin · May 23, 2024 · 3f54397 · 3f54397
1 parent 124ab91
commit 3f54397
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 2 deletions.
diff --git a/README.md b/README.md
@@ -335,6 +335,8 @@ Adds a role for a user:
 
 ```bash
 php artisan role:assign eve writer
+# Specify the ptype of the role assignment by using the --ptype option.
+php artisan role:assign eve writer --ptype=g2
 ```
 
 ### Using cache

diff --git a/src/Commands/RoleAssign.php b/src/Commands/RoleAssign.php
@@ -17,7 +17,8 @@ class RoleAssign extends Command
      */
     protected $signature = 'role:assign
                             {user : the identifier of user}
-                            {role : the name of role}';
+                            {role : the name of role}
+                            {--ptype= : the ptype of role}';
 
     /**
      * The console command description.
@@ -35,8 +36,9 @@ public function handle()
     {
         $user = $this->argument('user');
         $role = $this->argument('role');
+        $ptype = $this->option('ptype') ?: 'g';
 
-        $ret = Enforcer::addRoleForUser($user, $role);
+        $ret = Enforcer::addNamedGroupingPolicy($ptype, $user, $role);
         if ($ret) {
             $this->info('Added `'.$role.'` role to `'.$user.'` successfully');
         } else {

diff --git a/tests/Commands/RoleAssignTest.php b/tests/Commands/RoleAssignTest.php
@@ -19,5 +19,13 @@ public function testHandle()
         $exitCode = Artisan::call('role:assign', ['user' => 'eve', 'role' => 'writer']);
         $this->assertFalse(0 === $exitCode);
         $this->assertTrue(Enforcer::hasRoleForUser('eve', 'writer'));
+
+        Enforcer::getModel()->addDef('g', 'g2', '_,_');
+        $this->assertFalse(Enforcer::hasNamedGroupingPolicy('g2', 'eve', 'writer'));
+        $exitCode = Artisan::call('role:assign', ['user' => 'eve', 'role' => 'writer', '--ptype' => 'g2']);
+        $this->assertTrue(0 === $exitCode);
+        $exitCode = Artisan::call('role:assign', ['user' => 'eve', 'role' => 'writer', '--ptype' => 'g2']);
+        $this->assertFalse(0 === $exitCode);
+        $this->assertTrue(Enforcer::hasNamedGroupingPolicy('g2', 'eve', 'writer'));
     }
 }