Handling for when no required approvers are included #26
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| name: CI | |
| on: | |
| push: | |
| pull_request: | |
| jobs: | |
| test-approved-exact: | |
| runs-on: ubuntu-latest | |
| steps: | |
| - uses: actions/checkout@v4 | |
| - id: approved-by-required-users | |
| uses: ./ # Use the action | |
| with: | |
| token: ${{ secrets.GITHUB_TOKEN }} | |
| required-approvers-list: peternied | |
| min-required: 1 | |
| mock-approvers: 'peternied' | |
| mock-pr-number: 42 | |
| - if: steps.approved-by-required-users.outcome != 'success' || steps.approved-by-required-users.outputs.maintainer-approvals != 'peternied' | |
| run: echo "Unexpected outcome:${{ steps.approved-by-required-users.outcome }} or maintainer-approvals:${{steps.approved-by-required-users.outputs.maintainer-approvals}}" | |
| test-approved-exact-and-unimportant: | |
| runs-on: ubuntu-latest | |
| steps: | |
| - uses: actions/checkout@v4 | |
| - id: approved-by-required-users | |
| uses: ./ # Use the action | |
| with: | |
| token: ${{ secrets.GITHUB_TOKEN }} | |
| required-approvers-list: peternied | |
| min-required: 1 | |
| mock-approvers: 'peternied greengiant' | |
| mock-pr-number: 42 | |
| - if: steps.approved-by-required-users.outcome != 'success' || steps.approved-by-required-users.outputs.maintainer-approvals != 'peternied' | |
| run: echo "Unexpected outcome:${{ steps.approved-by-required-users.outcome }} or maintainer-approvals:${{steps.approved-by-required-users.outputs.maintainer-approvals}}" | |
| test-unapproved-none: | |
| runs-on: ubuntu-latest | |
| steps: | |
| - uses: actions/checkout@v4 | |
| - id: approved-by-required-users | |
| continue-on-error: true | |
| uses: ./ # Use the action | |
| with: | |
| token: ${{ secrets.GITHUB_TOKEN }} | |
| required-approvers-list: peternied | |
| min-required: 1 | |
| mock-approvers: ' ' | |
| mock-pr-number: 42 | |
| - if: steps.approved-by-required-users.outcome != 'failure' || steps.approved-by-required-users.outputs.maintainer-approvals != '' | |
| run: echo "Unexpected outcome:${{ steps.approved-by-required-users.outcome }} or maintainer-approvals:${{steps.approved-by-required-users.outputs.maintainer-approvals}}" | |
| test-unapproved-unimportant: | |
| runs-on: ubuntu-latest | |
| steps: | |
| - uses: actions/checkout@v4 | |
| - id: approved-by-required-users | |
| continue-on-error: true | |
| uses: ./ # Use the action | |
| with: | |
| token: ${{ secrets.GITHUB_TOKEN }} | |
| required-approvers-list: peternied | |
| min-required: 1 | |
| mock-approvers: 'greengiant' | |
| mock-pr-number: 42 | |
| - if: steps.approved-by-required-users.outcome != 'failure' || steps.approved-by-required-users.outputs.maintainer-approvals != '' | |
| run: echo "Unexpected outcome:${{ steps.approved-by-required-users.outcome }} or maintainer-approvals:${{steps.approved-by-required-users.outputs.maintainer-approvals}}" | |
| test-approved-too-few: | |
| runs-on: ubuntu-latest | |
| steps: | |
| - uses: actions/checkout@v4 | |
| - id: approved-by-required-users | |
| continue-on-error: true | |
| uses: ./ # Use the action | |
| with: | |
| token: ${{ secrets.GITHUB_TOKEN }} | |
| required-approvers-list: 'peternied, greengiant' | |
| min-required: 2 | |
| mock-approvers: 'peternied' | |
| mock-pr-number: 42 | |
| - if: steps.approved-by-required-users.outcome != 'failure' || steps.approved-by-required-users.outputs.maintainer-approvals != 'peternied' | |
| run: echo "Unexpected outcome:${{ steps.approved-by-required-users.outcome }} or maintainer-approvals:${{steps.approved-by-required-users.outputs.maintainer-approvals}}" | |
| test-approvers-match-strange-required-users-spacing: | |
| runs-on: ubuntu-latest | |
| steps: | |
| - uses: actions/checkout@v4 | |
| - id: approved-by-required-users | |
| continue-on-error: true | |
| uses: ./ # Use the action | |
| with: | |
| token: ${{ secrets.GITHUB_TOKEN }} | |
| required-approvers-list: 'peternied, greengiant, austin, billyjean robert' | |
| min-required: 4 | |
| mock-approvers: 'peternied greengiant austin billyjean robert' | |
| mock-pr-number: 42 | |
| - if: steps.approved-by-required-users.outcome != 'failure' || steps.approved-by-required-users.outputs.maintainer-approvals != 'peternied' | |
| run: echo "Unexpected outcome:${{ steps.approved-by-required-users.outcome }} or maintainer-approvals:${{steps.approved-by-required-users.outputs.maintainer-approvals}}" | |
| test-approved-by-anyone: | |
| runs-on: ubuntu-latest | |
| steps: | |
| - uses: actions/checkout@v4 | |
| - id: approved-by-required-users | |
| uses: ./ # Use the action | |
| with: | |
| token: ${{ secrets.GITHUB_TOKEN }} | |
| min-required: 2 | |
| mock-approvers: 'peternied bob kelly' | |
| mock-pr-number: 42 | |
| - if: steps.approved-by-required-users.outcome != 'failure' || steps.approved-by-required-users.outputs.maintainer-approvals != 'peternied bob kelly' | |
| run: echo "Unexpected outcome:${{ steps.approved-by-required-users.outcome }} or maintainer-approvals:${{steps.approved-by-required-users.outputs.maintainer-approvals}}" |