Handling for when no required approvers are included

Signed-off-by: Peter Nied <[email protected]>
peternied · Dec 6, 2023 · c5b2e81 · c5b2e81
1 parent 1ff344f
commit c5b2e81
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 2 deletions.
diff --git a/action.yml b/action.yml
@@ -19,6 +19,9 @@ inputs:
   mock-approvers:
     description: 'Used only for testing'
     required: false
+  mock-pr-number:
+    description: 'Used only for testing'
+    required: false
 
 outputs:
   specific-approvals:

diff --git a/dist/index.js b/dist/index.js
@@ -36751,7 +36751,7 @@ async function run() {
 
   const acceptedApprovers = [];
   pullRequestApprovers.forEach(approver => {
-    if (!requiredApprovers || requiredApprovers.filter(required => required === approver).length != 0) {
+    if (!requiredApprovers || !requiredApprovers.length || requiredApprovers.filter(required => required === approver).length != 0) {
         acceptedApprovers.push(approver);
     }
   });

diff --git a/index.js b/index.js
@@ -42,7 +42,7 @@ async function run() {
 
   const acceptedApprovers = [];
   pullRequestApprovers.forEach(approver => {
-    if (!requiredApprovers || requiredApprovers.filter(required => required === approver).length != 0) {
+    if (!requiredApprovers || !requiredApprovers.length || requiredApprovers.filter(required => required === approver).length != 0) {
         acceptedApprovers.push(approver);
     }
   });