Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release v15.3 #611

Merged
merged 9 commits into from
Nov 16, 2023
Merged

Release v15.3 #611

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
197119b
[FIX] Allow parametrized phase in EOM mode (#599)
HGSilveri Oct 19, 2023
b4741e9
Parametrized pulse in EOM fix
a-corni Nov 15, 2023
aec8f89
Restrict to mypy 1.1.1
a-corni Nov 15, 2023
aaaf837
Move to 1.3.0
a-corni Nov 15, 2023
8bf8cbd
Fix pydantic
a-corni Nov 15, 2023
714c80b
Blocking type checking of referencing.py
a-corni Nov 15, 2023
d228d33
skipping imports for referencing
a-corni Nov 16, 2023
c544ac3
silenting import errors with referencing
a-corni Nov 16, 2023
b4bffe5
Skip referencing in mypy
a-corni Nov 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion VERSION.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
0.15.2
0.15.3
2 changes: 1 addition & 1 deletion pulser-core/pulser/sequence/sequence.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1220,7 +1220,7 @@ def add_eom_pulse(
channel_obj = self.declared_channels[channel]
channel_obj.validate_duration(duration)
for arg in (phase, post_phase_shift):
if not isinstance(arg, (float, int)):
if not isinstance(arg, (Parametrized, float, int)):
raise TypeError("Phase values must be a numeric value.")
return

Expand Down
7 changes: 5 additions & 2 deletions tests/test_paramseq.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -319,13 +319,16 @@ def test_parametrized_before_eom_mode(mod_device):
with pytest.raises(ValueError, match="duration has to be at least"):
seq.add_eom_pulse("ch0", 0, 0.0)

seq.add_eom_pulse("ch0", 100, 0.0)
var = seq.declare_variable("var", dtype=float, size=None)
seq.add_eom_pulse("ch0", 100, 0.0, post_phase_shift=var)
seq.add_eom_pulse("ch0", var * 1000, np.pi)
seq.add_eom_pulse("ch0", 200, var)

seq.disable_eom_mode("ch0")
assert not seq.is_in_eom_mode("ch0")

# Just check that building works
seq.build(amp=3.0)
seq.build(amp=3.0, var=0.5)


def test_iterable_variable_check():
Expand Down
Loading