Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v15.3 #611

Merged
merged 9 commits into from
Nov 16, 2023
Merged

Release v15.3 #611

merged 9 commits into from
Nov 16, 2023

Conversation

a-corni
Copy link
Collaborator

@a-corni a-corni commented Nov 15, 2023

Making a hot fix to enable the use of parametrized phase in eom mode.

@a-corni a-corni requested a review from madagra November 15, 2023 14:00
Copy link
Collaborator

@madagra madagra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@madagra
Copy link
Collaborator

madagra commented Nov 15, 2023

@a-corni you should likely use MyPy v1.6.1 in order to make the tests pass.

@madagra madagra added the enhancement New feature or request label Nov 15, 2023
@a-corni
Copy link
Collaborator Author

a-corni commented Nov 15, 2023

@a-corni you should likely use MyPy v1.6.1 in order to make the tests pass.

MyPy version is kept at 1.2... I will keep investigating 🔍

@a-corni
Copy link
Collaborator Author

a-corni commented Nov 15, 2023

The error seems to be coming from the module referencing. They made a new release on Nov. 14th and the error shown (see below) points directly to it according to this issue on mypy

/opt/hostedtoolcache/Python/3.9.18/x64/lib/python3.9/site-packages/referencing/jsonschema.py:499: error: Invalid "type: ignore" comment [syntax]

I have followed what the mypy developpers suggested there: Add to mypy.ini:

[mypy-discord.*]
follow_imports = skip

But this does not seem to have changed anything - which is weird, it should have deleted the error messages coming from referencing...

@a-corni
Copy link
Collaborator Author

a-corni commented Nov 16, 2023

The error seems to be coming from the module referencing. They made a new release on Nov. 14th and the error shown (see below) points directly to it according to this issue on mypy

/opt/hostedtoolcache/Python/3.9.18/x64/lib/python3.9/site-packages/referencing/jsonschema.py:499: error: Invalid "type: ignore" comment [syntax]

I have followed what the mypy developpers suggested there: Add to mypy.ini:

[mypy-discord.*]
follow_imports = skip

But this does not seem to have changed anything - which is weird, it should have deleted the error messages coming from referencing...

Solved by using skip instead of silent (it makes a difference in the end)

@a-corni a-corni merged commit e1dcf47 into master Nov 16, 2023
8 checks passed
@a-corni a-corni deleted the release_v15_3 branch November 16, 2023 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants