fix last TODO

paritytech · Oct 25, 2023 · 4fca041 · 4fca041
1 parent 0c99786
commit 4fca041
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 7 deletions.
diff --git a/src/errors/checkXcmTxInputs.spec.ts b/src/errors/checkXcmTxInputs.spec.ts
@@ -861,7 +861,7 @@ describe('checkParaAssets', () => {
 			expect(registry.cacheLookupPoolAsset('0')).toEqual({
 				lpToken: '0',
 				pairInfo:
-					'[[{"parents":0,"interior":{"here":null}},{"parents":0,"interior":{"x2":[{"palletInstance":50},{"generalIndex":100}]}}]]',
+					'[[{"parents":"0","interior":{"Here":""}},{"parents":"0","interior":{"X2":[{"PalletInstance":"50"},{"GeneralIndex":"100"}]}}]]',
 			});
 		});
 	});

diff --git a/src/errors/checkXcmTxInputs.ts b/src/errors/checkXcmTxInputs.ts
@@ -361,11 +361,6 @@ export const checkLiquidTokenValidity = async (
 		for (let i = 0; i < poolAssets.length; i++) {
 			const poolAsset = poolAssets[i];
 			const poolAssetData = JSON.stringify(poolAsset[0].toHuman()).replace(/(\d),/g, '$1');
-			// TODO: remove this createType
-			const palletAssetConversionNativeOrAssetIdData = api.registry.createType(
-				'Vec<Vec<MultiLocation>>',
-				JSON.parse(poolAssetData)
-			);
 
 			const poolAssetInfo = poolAsset[1].unwrap();
 			if (poolAssetInfo.lpToken.toString() === assetId) {
@@ -374,7 +369,7 @@ export const checkLiquidTokenValidity = async (
 					pairInfo: string;
 				} = {
 					lpToken: assetId,
-					pairInfo: JSON.stringify(palletAssetConversionNativeOrAssetIdData.toJSON()),
+					pairInfo: poolAssetData,
 				};
 
 				// cache the queried liquidToken asset