Skip to content

Commit

Permalink
resolve some todos
Browse files Browse the repository at this point in the history
  • Loading branch information
TarikGul committed Oct 25, 2023
1 parent ec64273 commit 0c99786
Show file tree
Hide file tree
Showing 3 changed files with 1 addition and 6 deletions.
1 change: 0 additions & 1 deletion src/createXcmTypes/SystemToPara.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -287,7 +287,6 @@ describe('SystemToPara XcmVersioned Generation', () => {

describe('createSystemToParaMultiAssets', () => {
it('Should correctly create system multi assets for SystemToPara xcm direction', async () => {
// TODO: This is unsorted, and once the sorting is fixed this test should be switch to ordered assets
const expected: FungibleStrMultiAsset[] = [
{
fun: {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -35,10 +35,7 @@ const checkForeignAssetExists = (
});

for (const asset of foreignAssets) {
// TODO: How to ensure 2 foreign assets are exactly the same. Best
// to sanitize both then compare. Also what if some value is of a `parents: number` and another
// is of `parents: string`...

// We sanitize `assets` here since multiLocation is already sanitized.
if (JSON.stringify(sanitizeKeys(JSON.parse(asset))) === JSON.stringify(multiLocation)) {
return true;
}
Expand Down
1 change: 0 additions & 1 deletion src/createXcmTypes/util/sortMultiAssetsAscending.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -278,7 +278,6 @@ describe('sortMultiAssetsAscending', () => {
});

it('Should correctly sort an unsorted multiasset array with in ascending order when parents values are different', () => {
// TODO: verify if the refactor of this test is correct.
const multiAssets: FungibleStrMultiAsset[] = [
{
fun: {
Expand Down

0 comments on commit 0c99786

Please sign in to comment.