[Option 2] Update vault.accountAppBalanceDelta logic flow from app #205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ChefMist
commented
Nov 6, 2024
| 142393 |
There was a problem hiding this comment.
big gas saving for this case when the delta negate each other -- so reserveOfApp do not even update at all
ChefSnoopy
approved these changes
Nov 6, 2024
chefburger
approved these changes
Nov 7, 2024
ChefMist
added a commit
that referenced
this pull request
Nov 7, 2024
* feat: include code <wip> test * test: add bin test on swap/mint/burn return delta * feat: include cl related test on hook delta * test: include gas snapshot * feat: pr comment - do not pass msg.sender * [Option 2] Update vault.accountAppBalanceDelta logic flow from app (#205) * feat: add additional method on vault to account app balance delta * feat: remove redundant non zero checkl * feat: further optimise the vault logic * feat: add more test on vault * minor: update comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extends #203
vault.accountAppBalanceDeltalogic flow from app #203, if hook delta is involved, it can make 4 seperate call to vault viavault.accountAppBalanceDeltaIf we decide to go for this, might need to add more test on Vault level potentially