Update vault.accountAppBalanceDelta logic flow from app
#203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
chefburger
reviewed
Nov 5, 2024
ChefSnoopy
reviewed
Nov 6, 2024
| BalanceDelta delta, | ||
| BalanceDelta hookDelta, | ||
| address settler | ||
| ) internal { |
There was a problem hiding this comment.
Still thinking if we add a new function accountAppBalanceDelta in vault, pass all delta once , will reduce call times , maybe will save some gas
There was a problem hiding this comment.
yeh, will check on this after all tests added
ChefMist
changed the title
vault.accountAppBalanceDelta logic flow from app vault.accountAppBalanceDelta logic flow from app
|
applied #205 on this PR as we prefer making the changes on vault (gas savings) |
ChefSnoopy
reviewed
Nov 7, 2024
| library VaultAppDeltaSettlement { | ||
| /// @notice helper method to call `vault.accountAppBalanceDelta` | ||
| /// @dev Vault maintains a `reserveOfApp` to protect against exploits in one app from accessing funds in another. | ||
| /// To prevent underflow in `reserveOfApp`, it is essential to handle `appDelta` and `hookDelta` in a specific order. |
There was a problem hiding this comment.
do we still need this comments ，"it is essential to handle ...."?
because now no order logic.
_accountDeltaForApp(currency0, delta0 + hookDelta0);
_accountDeltaForApp(currency1, delta1 + hookDelta1);
There was a problem hiding this comment.
thanks, cleaned up
ChefMist
dismissed stale reviews from chef-omelette and ChefSnoopy
via
f224fa6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
hookDeltaanddeltaare sent tovault.accountAppBalanceDeltahookDeltathendelta-- however this might lead tounderflowscenario onreservesOfAppThis PR fixes it by ensuring we send the delta or hookDelta which increases reserveOfApp before deducting reserveOfApp