Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adding reusable CustomAppBar class for consistent app bar across all platforms #43

Open
wants to merge 10 commits into
base: develop
Choose a base branch
from

Conversation

esmaeil-ahmadipour
Copy link
Collaborator

No description provided.

@esmaeil-ahmadipour esmaeil-ahmadipour added the feature Add/Create new feature label Dec 19, 2024
@esmaeil-ahmadipour esmaeil-ahmadipour self-assigned this Dec 19, 2024
@esmaeil-ahmadipour esmaeil-ahmadipour linked an issue Dec 19, 2024 that may be closed by this pull request
@esmaeil-ahmadipour esmaeil-ahmadipour force-pushed the feature/custom-window-header branch from e7ac885 to 5d461fe Compare December 19, 2024 12:41
…oss all platforms

- defined `CustomAppBar` class
- set `CustomAppBar` in `WelcomePage` class
@esmaeil-ahmadipour esmaeil-ahmadipour force-pushed the feature/custom-window-header branch from 5d461fe to 12dcc38 Compare December 19, 2024 12:44
height: preferredSize.height,
padding: const EdgeInsets.symmetric(horizontal: 10),
decoration: BoxDecoration(
color: Colors.grey[900],

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The application supports light & dark mode. Please remove the hardcode of the background.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@phoenixit99 / @PouriaMoradi021

These colors should be defined and managed within a color palette.
The application should support switching between light and dark themes.

Dependencies:

child: Text(
'Linux-like AppBar',
style: TextStyle(color: Colors.white, fontSize: 16),
),

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please replace the text to the logo

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These colors should be defined and managed within a color palette and text styles.
The application should support switching between light and dark themes.

Dependencies:

color: Colors.red,
onPressed: () async {
await windowManager.close();
},

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The color of the button is not correct. Please change follow the design
Light mode: #242424
Dark mode: #FFFFFF

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These colors should be defined and managed within a color palette and text styles.
The application should support switching between light and dark themes.

Dependencies:

@PouriaMoradi021 PouriaMoradi021 self-assigned this Dec 27, 2024
@PouriaMoradi021 PouriaMoradi021 force-pushed the feature/custom-window-header branch from ded6377 to 53bf572 Compare December 27, 2024 14:47
@PouriaMoradi021 PouriaMoradi021 force-pushed the feature/custom-window-header branch from 67581a5 to 5afc6a9 Compare January 2, 2025 10:03
- add `toggle switch` to customized app bar
- add `FluentAppBarButton` class

BREAKING-CHANGE:
toggle switch code is commented cause of interupting with material & fluent in Theme class in changing theme action. once theme migrate to fluent version it can be uncommented.
@PouriaMoradi021 PouriaMoradi021 force-pushed the feature/custom-window-header branch from 5afc6a9 to 1867e1d Compare January 2, 2025 10:04
- add documents for text styles with name in figma design
- add documents for text styles that have no name & named by us & equating them to named fonts to simplify searching process
@PouriaMoradi021 PouriaMoradi021 force-pushed the feature/custom-window-header branch from 383a980 to 72c0ccb Compare January 2, 2025 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Add/Create new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement Custom Window Header for Desktop Platforms
3 participants