-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: adding reusable CustomAppBar
class for consistent app bar across all platforms
#43
base: develop
Are you sure you want to change the base?
Conversation
e7ac885
to
5d461fe
Compare
…oss all platforms - defined `CustomAppBar` class - set `CustomAppBar` in `WelcomePage` class
5d461fe
to
12dcc38
Compare
height: preferredSize.height, | ||
padding: const EdgeInsets.symmetric(horizontal: 10), | ||
decoration: BoxDecoration( | ||
color: Colors.grey[900], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The application supports light & dark mode. Please remove the hardcode of the background.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@phoenixit99 / @PouriaMoradi021
These colors should be defined and managed within a color palette.
The application should support switching between light and dark themes.
Dependencies:
- This feature depends on the resolution of Pull Request Migrate to Fluent UI Framework #45.
- Access to the Figma design system is required.
child: Text( | ||
'Linux-like AppBar', | ||
style: TextStyle(color: Colors.white, fontSize: 16), | ||
), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please replace the text to the logo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These colors should be defined and managed within a color palette and text styles.
The application should support switching between light and dark themes.
Dependencies:
- This feature depends on the resolution of Pull Request Migrate to Fluent UI Framework #45.
- Access to the Figma design system is required.
color: Colors.red, | ||
onPressed: () async { | ||
await windowManager.close(); | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The color of the button is not correct. Please change follow the design
Light mode: #242424
Dark mode: #FFFFFF
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These colors should be defined and managed within a color palette and text styles.
The application should support switching between light and dark themes.
Dependencies:
- This feature depends on the resolution of Pull Request Migrate to Fluent UI Framework #45.
- Access to the Figma design system is required.
- approved by [email protected]
ded6377
to
53bf572
Compare
67581a5
to
5afc6a9
Compare
- add `toggle switch` to customized app bar - add `FluentAppBarButton` class BREAKING-CHANGE: toggle switch code is commented cause of interupting with material & fluent in Theme class in changing theme action. once theme migrate to fluent version it can be uncommented.
5afc6a9
to
1867e1d
Compare
- add documents for text styles with name in figma design - add documents for text styles that have no name & named by us & equating them to named fonts to simplify searching process
383a980
to
72c0ccb
Compare
No description provided.