Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Custom Window Header for Desktop Platforms #42

Open
esmaeil-ahmadipour opened this issue Dec 13, 2024 · 4 comments · May be fixed by #43
Open

Implement Custom Window Header for Desktop Platforms #42

esmaeil-ahmadipour opened this issue Dec 13, 2024 · 4 comments · May be fixed by #43
Assignees
Labels
feature Add/Create new feature

Comments

@esmaeil-ahmadipour
Copy link
Collaborator

esmaeil-ahmadipour commented Dec 13, 2024

Overview

Feature Description

This feature involves customizing the window header on the desktop version of the app by using the window_manager package. The goal is to implement a custom header with user-defined controls. (only on registration route & according figma design)

For the development of this feature, the window_manager package in Flutter will be used.

Design Reference

Screenshot : Custom Window Header (Light Mode) 🖼️

image

Screenshot : Custom Window Header (Dark Mode) 🖼️

image

Platform-Specific Implementations

  • Windows: Ensure that the custom header aligns well with the Windows desktop environment and functions as expected when dragging or resizing the window.
  • Linux: Ensure compatibility and consistency with Linux desktop environments, making sure custom controls are functional.
  • macOS: Ensure that the custom header integrates well with macOS's window management and styling, while also supporting window dragging and resizing.
  • Web: There is currently no Figma design available for Web .HOLD
  • Android: There is currently no Figma design available for Android.HOLD
  • iOS: There is currently no Figma design available for iOS .HOLD

Related Issues

@phoenixit99
Copy link

Hi @esmaeil-ahmadipour
I have some concerns about the feature. I see that the header has two scenarios:

Without Completed Setup: (Theme switcher, minimize, maximize, close icons)
Already Set Up: (Dashboard page: Transaction, Wallet, Logs icons)
Does this PR cover both scenarios, or should we create another issue?

@PouriaMoradi021
Copy link

PouriaMoradi021 commented Dec 26, 2024

📊 Current Status:

Progress: 90%

  • ✔️ Completed Tasks:

    • Task 1: add/update interTextStyles according to new changes by design team in Figma
    • Task 2: update AppThemeData & add lightTypography & darkTypography in it
    • Task 3: make windows header curved (Doing in another issue)
    • Task 3: customized windows header for registeration scenario that has (Theme switcher, minimize, maximize, close icons)
    • Task 4: add documents according to mark down standards
    • Task 5: reformat / code styles

🚧 Challenges/Blockers:

  • Not identified

🛤️ Next Steps:

  • Estimated time for completion: 1D

❓ Questions/Requests:

  • Not identified

@esmaeil-ahmadipour

@esmaeil-ahmadipour
Copy link
Collaborator Author

esmaeil-ahmadipour commented Dec 26, 2024

Does this PR cover both scenarios, or should we create another issue?
Thank you for your attention @phoenixit99 ! .This requires separate development, and a related issue will be created based on this comment. (new issue #49 )

PouriaMoradi021 added a commit that referenced this issue Dec 27, 2024
PouriaMoradi021 added a commit that referenced this issue Dec 27, 2024


- update `AppThemeData` & add `lightTypography` & `darkTypography` in it
PouriaMoradi021 added a commit that referenced this issue Jan 2, 2025
- add `toggle switch` to customized app bar
- add `FluentAppBarButton` class

BREAKING-CHANGE:
toggle switch code is commented cause of interupting with material & fluent in Theme class in changing theme action. once theme migrate to fluent version it can be uncommented.
PouriaMoradi021 added a commit that referenced this issue Jan 2, 2025
- add `toggle switch` to customized app bar
- add `FluentAppBarButton` class

BREAKING-CHANGE:
toggle switch code is commented cause of interupting with material & fluent in Theme class in changing theme action. once theme migrate to fluent version it can be uncommented.
PouriaMoradi021 added a commit that referenced this issue Jan 2, 2025
- add `toggle switch` to customized app bar
- add `FluentAppBarButton` class

BREAKING-CHANGE:
toggle switch code is commented cause of interupting with material & fluent in Theme class in changing theme action. once theme migrate to fluent version it can be uncommented.
PouriaMoradi021 added a commit that referenced this issue Jan 2, 2025
- add documents for text styles with name in figma design
- add documents for text styles that have no name & named by us & equating them to named fonts to simplify searching process
@PouriaMoradi021
Copy link

Open points that require decision-making :

1- The window opened rounding. The application needs more time to search and prepare its data, which should be examined in a separate issue.


  • To implement the toggle switch related to changing the theme in the app, the corresponding barcode was implemented using a widget in Fluent UI, but due to a conflict between the material in the theme and Fluent UI, I was unable to implement the methods related to changing the theme so that the theme could be implemented based on Fluent UI.

@esmaeil-ahmadipour

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Add/Create new feature
Projects
None yet
3 participants