Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(minifier): a != null ? a : b -> a ?? b #8352

Merged
merged 1 commit into from
Jan 9, 2025
Merged

feat(minifier): a != null ? a : b -> a ?? b #8352

merged 1 commit into from
Jan 9, 2025

Conversation

camc314
Copy link
Contributor

@camc314 camc314 commented Jan 8, 2025

No description provided.

@Boshen Boshen mentioned this pull request Jan 8, 2025
Merged
@github-actions github-actions bot added A-minifier Area - Minifier C-enhancement Category - New feature or request labels Jan 8, 2025
@camc314 Graphite App
Copy link
Contributor Author

camc314 commented Jan 8, 2025 •
edited
Loading

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@camc314 camc314 mentioned this pull request Jan 8, 2025
Merged
@camc314 camc314 marked this pull request as ready for review January 8, 2025 17:33
@camc314 camc314 requested a review from Boshen January 8, 2025 17:33
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Jan 8, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #8352 will not alter performance

Comparing c/01-08-feat_minifier_a_null_a_b_-a_b (793cb43) with main (1c4658d)

Summary

✅ 29 untouched benchmarks

@camc314 camc314 force-pushed the c/01-08-feat_minifier_a_null_a_b_-_a_b_ branch 2 times, most recently from 642dd28 to 81b6712 Compare January 8, 2025 22:28
@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Jan 9, 2025
@Boshen Graphite App
Copy link
Member

Boshen commented Jan 9, 2025 •
edited by graphite-app bot
Loading

Merge activity

  • Jan 8, 9:46 PM EST: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Jan 8, 10:57 PM EST: Graphite disabled "merge when ready" on this PR due to: a merge conflict with the target branch; resolve the conflict and try again..
  • Jan 8, 10:57 PM EST: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Jan 8, 10:57 PM EST: Graphite disabled "merge when ready" on this PR due to: a merge conflict with the target branch; resolve the conflict and try again..
  • Jan 8, 10:57 PM EST: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Jan 9, 5:12 AM EST: A user added this pull request to the Graphite merge queue.
  • Jan 9, 5:17 AM EST: A user merged this pull request with the Graphite merge queue.

@Boshen Boshen changed the base branch from c/01-08-feat_minifier_port_esbuild_conditional_expr_minification to graphite-base/8352 January 9, 2025 02:47
@Boshen Boshen force-pushed the c/01-08-feat_minifier_a_null_a_b_-_a_b_ branch from 81b6712 to fa8c1db Compare January 9, 2025 03:05
@Boshen Boshen force-pushed the graphite-base/8352 branch from 22bcc3a to f367a16 Compare January 9, 2025 03:05
@Boshen Boshen changed the base branch from graphite-base/8352 to main January 9, 2025 03:06
@Boshen Boshen force-pushed the c/01-08-feat_minifier_a_null_a_b_-_a_b_ branch from fa8c1db to 1ff4df0 Compare January 9, 2025 03:06
@camc314 camc314 force-pushed the c/01-08-feat_minifier_a_null_a_b_-_a_b_ branch from 1ff4df0 to 1193ff6 Compare January 9, 2025 09:20
@Boshen Boshen force-pushed the c/01-08-feat_minifier_a_null_a_b_-_a_b_ branch from 1193ff6 to 793cb43 Compare January 9, 2025 10:12
@graphite-app graphite-app bot merged commit 793cb43 into main Jan 9, 2025
25 checks passed
@graphite-app graphite-app bot deleted the c/01-08-feat_minifier_a_null_a_b_-_a_b_ branch January 9, 2025 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Boshen Boshen Awaiting requested review from Boshen

Assignees
No one assigned
Labels
0-merge Merge with Graphite Merge Queue A-minifier Area - Minifier C-enhancement Category - New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@camc314 @Boshen