Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(minifier): remove the buggy minimize_exit_points implementation #8349

Conversation

Boshen
Copy link
Member

@Boshen Boshen commented Jan 8, 2025

No description provided.

Copy link
Member Author

Boshen commented Jan 8, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added A-minifier Area - Minifier C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Jan 8, 2025
Copy link

codspeed-hq bot commented Jan 8, 2025

CodSpeed Performance Report

Merging #8349 will improve performances by ×2.6

Comparing 01-08-refactor_minifier_remove_the_buggy_minimize_exit_points_implementation (09f0f48) with main (b6c1546)

Summary

⚡ 3 improvements
✅ 26 untouched benchmarks

Benchmarks breakdown

Benchmark main 01-08-refactor_minifier_remove_the_buggy_minimize_exit_points_implementation Change
minifier[antd.js] 226 ms 198.8 ms +13.72%
minifier[react.development.js] 1.5 ms 1.3 ms +19.09%
minifier[typescript.js] 766.2 ms 292.1 ms ×2.6

Copy link

graphite-app bot commented Jan 8, 2025

Merge activity

  • Jan 8, 8:43 AM EST: Graphite disabled "merge when ready" on this PR due to: a merge conflict with the target branch; resolve the conflict and try again..
  • Jan 8, 9:46 PM EST: A user added this pull request to the Graphite merge queue.
  • Jan 8, 10:00 PM EST: A user merged this pull request with the Graphite merge queue.

@camc314
Copy link
Contributor

camc314 commented Jan 8, 2025

do you know which parts were buggy?

@camc314 camc314 force-pushed the 01-08-refactor_minifier_remove_the_buggy_minimize_exit_points_implementation branch from c22a939 to 127772d Compare January 8, 2025 16:58
@graphite-app graphite-app bot added the 0-merge Merge with Graphite Merge Queue label Jan 9, 2025
@Boshen Boshen force-pushed the 01-08-refactor_minifier_remove_the_buggy_minimize_exit_points_implementation branch from 127772d to 695fe58 Compare January 9, 2025 02:47
@Boshen Boshen force-pushed the 01-08-refactor_minifier_remove_the_buggy_minimize_exit_points_implementation branch from 695fe58 to 09f0f48 Compare January 9, 2025 02:49
@graphite-app graphite-app bot merged commit 09f0f48 into main Jan 9, 2025
25 checks passed
@graphite-app graphite-app bot deleted the 01-08-refactor_minifier_remove_the_buggy_minimize_exit_points_implementation branch January 9, 2025 03:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0-merge Merge with Graphite Merge Queue A-minifier Area - Minifier C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants