Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(transformer/arrow-functions): add TODO comments #8328

Conversation

overlookmotel
Copy link
Contributor

@overlookmotel overlookmotel commented Jan 7, 2025

Add some TODO comments for this transform.

Copy link
Contributor Author

overlookmotel commented Jan 7, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@overlookmotel
Copy link
Contributor Author

overlookmotel commented Jan 7, 2025

@Dunqing This PR, #8322 and #8318 are the only interesting things in this stack. The rest is all code style/refactor.

I've made this PR with TODO comments because I don't want to get caught up right now in trying to fix them, but I thought I should document what I've noticed somewhere.

Copy link

codspeed-hq bot commented Jan 7, 2025

CodSpeed Performance Report

Merging #8328 will create unknown performance changes

Comparing 01-07-refactor_transformer_arrow-functions_add_todo_comments (ce6c445) with 01-07-refactor_transformer_arrow-functions_reduce_repeated_code (73d0025)

Summary

🆕 29 new benchmarks

Benchmarks breakdown

Benchmark 01-07-refactor_transformer_arrow-functions_reduce_repeated_code 01-07-refactor_transformer_arrow-functions_add_todo_comments Change
🆕 codegen[checker.ts] N/A 25.1 ms N/A
🆕 codegen_sourcemap[checker.ts] N/A 68.6 ms N/A
🆕 isolated-declarations[vue-id.ts] N/A 725 ms N/A
🆕 lexer[RadixUIAdoptionSection.jsx] N/A 24 µs N/A
🆕 lexer[antd.js] N/A 22.3 ms N/A
🆕 lexer[cal.com.tsx] N/A 5.5 ms N/A
🆕 lexer[checker.ts] N/A 13.2 ms N/A
🆕 lexer[pdf.mjs] N/A 3.6 ms N/A
🆕 linter[RadixUIAdoptionSection.jsx] N/A 2.5 ms N/A
🆕 linter[cal.com.tsx] N/A 1.1 s N/A
🆕 linter[checker.ts] N/A 2.7 s N/A
🆕 minifier[antd.js] N/A 239.5 ms N/A
🆕 minifier[react.development.js] N/A 1.6 ms N/A
🆕 minifier[typescript.js] N/A 829 ms N/A
🆕 parser[RadixUIAdoptionSection.jsx] N/A 87.4 µs N/A
🆕 parser[antd.js] N/A 107.2 ms N/A
🆕 parser[cal.com.tsx] N/A 29.6 ms N/A
🆕 parser[checker.ts] N/A 54 ms N/A
🆕 parser[pdf.mjs] N/A 17.5 ms N/A
🆕 semantic[RadixUIAdoptionSection.jsx] N/A 74.2 µs N/A
... ... ... ... ...

ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.

@Dunqing
Copy link
Member

Dunqing commented Jan 8, 2025

@Dunqing This PR, #8322 and #8318 are the only interesting things in this stack. The rest is all code style/refactor.

All PRs are good, I made some careless mistakes.

I've made this PR with TODO comments because I don't want to get caught up right now in trying to fix them, but I thought I should document what I've noticed somewhere.

After this PR, I just realized my fixer is still incomplete.

@Dunqing Dunqing added the 0-merge Merge with Graphite Merge Queue label Jan 8, 2025
Copy link
Member

Dunqing commented Jan 8, 2025

Merge activity

  • Jan 7, 8:31 PM EST: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Jan 7, 8:32 PM EST: A user added this pull request to the Graphite merge queue.
  • Jan 7, 9:16 PM EST: A user merged this pull request with the Graphite merge queue.

@Dunqing Dunqing force-pushed the 01-07-refactor_transformer_arrow-functions_reduce_repeated_code branch from 28469ba to 65ed432 Compare January 8, 2025 01:36
Dunqing pushed a commit that referenced this pull request Jan 8, 2025
Add some TODO comments for this transform.
@Dunqing Dunqing force-pushed the 01-07-refactor_transformer_arrow-functions_add_todo_comments branch from e43c752 to 8bf4849 Compare January 8, 2025 01:37
Add some TODO comments for this transform.
@Dunqing Dunqing force-pushed the 01-07-refactor_transformer_arrow-functions_reduce_repeated_code branch from 65ed432 to 73d0025 Compare January 8, 2025 01:55
@Dunqing Dunqing force-pushed the 01-07-refactor_transformer_arrow-functions_add_todo_comments branch from 8bf4849 to ce6c445 Compare January 8, 2025 01:55
Base automatically changed from 01-07-refactor_transformer_arrow-functions_reduce_repeated_code to main January 8, 2025 02:14
@graphite-app graphite-app bot merged commit ce6c445 into main Jan 8, 2025
28 checks passed
@graphite-app graphite-app bot deleted the 01-07-refactor_transformer_arrow-functions_add_todo_comments branch January 8, 2025 02:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0-merge Merge with Graphite Merge Queue A-transformer Area - Transformer / Transpiler C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants