Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(transformer/arrow-functions): reorder visitor methods #8320

Merged
merged 1 commit into from
Jan 8, 2025
Merged

refactor(transformer/arrow-functions): reorder visitor methods #8320

merged 1 commit into from
Jan 8, 2025

Conversation

overlookmotel
Copy link
Contributor

@overlookmotel overlookmotel commented Jan 7, 2025 •
edited
Loading

Follow-on after #8024. Pure refactor.

Re-order the methods of the ConstructorBodyThisAfterSuperInserter visitor. Intent is that the call path flows from top to bottom, so the "story" makes sense when you read the code starting from the top.

This was referenced Jan 7, 2025
Merged
Merged
@overlookmotel Graphite App
Copy link
Contributor Author

overlookmotel commented Jan 7, 2025 •
edited
Loading

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

This was referenced Jan 7, 2025
Merged
Merged
Merged
Merged
@github-actions github-actions bot added A-transformer Area - Transformer / Transpiler C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Jan 7, 2025
@overlookmotel overlookmotel marked this pull request as ready for review January 7, 2025 14:21
@overlookmotel overlookmotel requested a review from Dunqing as a code owner January 7, 2025 14:21
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Jan 7, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #8320 will not alter performance

Comparing 01-07-refactor_transformer_arrow-functions_reorder_visitor_methods (ea9cefb) with main (aebe0ea)

Summary

✅ 29 untouched benchmarks

@overlookmotel overlookmotel force-pushed the 01-07-refactor_transformer_arrow-functions_rename_lifetime branch from 2181b85 to ae2224f Compare January 7, 2025 14:46
@overlookmotel overlookmotel force-pushed the 01-07-refactor_transformer_arrow-functions_reorder_visitor_methods branch from b3566eb to 6e071ec Compare January 7, 2025 14:46
@overlookmotel overlookmotel mentioned this pull request Jan 7, 2025
Merged
@graphite-app graphite-app bot added the 0-merge Merge with Graphite Merge Queue label Jan 8, 2025
@graphite-app Graphite App
Copy link

graphite-app bot commented Jan 8, 2025 •
edited
Loading

Merge activity

@Dunqing Dunqing force-pushed the 01-07-refactor_transformer_arrow-functions_rename_lifetime branch from ae2224f to 9127571 Compare January 8, 2025 01:34
Dunqing pushed a commit that referenced this pull request Jan 8, 2025
@overlookmotel
refactor(transformer/arrow-functions): reorder visitor methods (#8320)
32a0ee9 
Follow-on after #8024. Pure refactor.

Re-order the methods of the `ConstructorBodyThisAfterSuperInserter` visitor. Intent is that the call path flows from top to bottom, so the "story" makes sense when you read the code starting from the top.
@Dunqing Dunqing force-pushed the 01-07-refactor_transformer_arrow-functions_reorder_visitor_methods branch from 6e071ec to 32a0ee9 Compare January 8, 2025 01:34
@overlookmotel
refactor(transformer/arrow-functions): reorder visitor methods (#8320)
ea9cefb 
Follow-on after #8024. Pure refactor.

Re-order the methods of the `ConstructorBodyThisAfterSuperInserter` visitor. Intent is that the call path flows from top to bottom, so the "story" makes sense when you read the code starting from the top.
@Dunqing Dunqing force-pushed the 01-07-refactor_transformer_arrow-functions_rename_lifetime branch from 9127571 to 37199a4 Compare January 8, 2025 01:52
@Dunqing Dunqing force-pushed the 01-07-refactor_transformer_arrow-functions_reorder_visitor_methods branch from 32a0ee9 to ea9cefb Compare January 8, 2025 01:53
Base automatically changed from 01-07-refactor_transformer_arrow-functions_rename_lifetime to main January 8, 2025 01:59
@graphite-app graphite-app bot merged commit ea9cefb into main Jan 8, 2025
27 checks passed
@graphite-app graphite-app bot deleted the 01-07-refactor_transformer_arrow-functions_reorder_visitor_methods branch January 8, 2025 02:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dunqing Dunqing Awaiting requested review from Dunqing Dunqing is a code owner

Assignees
No one assigned
Labels
0-merge Merge with Graphite Merge Queue A-transformer Area - Transformer / Transpiler C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@overlookmotel