-
-
Notifications
You must be signed in to change notification settings - Fork 486
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(transformer/class-properties): override fixtures #7689
Merged
graphite-app
merged 1 commit into
main
from
12-05-test_transformer_class-properties_override_fixtures
Dec 8, 2024
Merged
test(transformer/class-properties): override fixtures #7689
graphite-app
merged 1 commit into
main
from
12-05-test_transformer_class-properties_override_fixtures
Dec 8, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Your org has enabled the Graphite merge queue for merging into mainAdd the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
github-actions
bot
added
A-transformer
Area - Transformer / Transpiler
C-test
Category - Testing. Code is missing test cases, or a PR is adding them
labels
Dec 5, 2024
overlookmotel
force-pushed
the
12-05-test_transformer_update_fixtures_script_support_overrides
branch
from
December 5, 2024 22:46
5eb208b
to
0953eee
Compare
overlookmotel
force-pushed
the
12-05-test_transformer_class-properties_override_fixtures
branch
from
December 5, 2024 22:46
118ff98
to
05e3be2
Compare
overlookmotel
force-pushed
the
12-05-test_transformer_update_fixtures_script_support_overrides
branch
from
December 6, 2024 14:26
0953eee
to
05a1a76
Compare
overlookmotel
force-pushed
the
12-05-test_transformer_class-properties_override_fixtures
branch
from
December 6, 2024 14:26
05e3be2
to
c0e731d
Compare
overlookmotel
force-pushed
the
12-05-test_transformer_update_fixtures_script_support_overrides
branch
from
December 6, 2024 18:09
05a1a76
to
d1ab894
Compare
overlookmotel
force-pushed
the
12-05-test_transformer_class-properties_override_fixtures
branch
from
December 6, 2024 18:09
c0e731d
to
e346fc4
Compare
This was referenced Dec 6, 2024
overlookmotel
force-pushed
the
12-05-test_transformer_update_fixtures_script_support_overrides
branch
from
December 7, 2024 18:59
d1ab894
to
13881e6
Compare
overlookmotel
force-pushed
the
12-05-test_transformer_class-properties_override_fixtures
branch
from
December 7, 2024 18:59
e346fc4
to
aca4fd0
Compare
This was referenced Dec 7, 2024
Merge activity
|
Override some transform conformance test fixtures for class properties transform, where: * Our output differs from Babel in cosmetic manner only. * Our transform intentionally works differently from Babel. * Babel's fixtures enable arrow functions transform, which malfunctions in our implementation. But we're not trying to test arrow functions transform here, so disable it.
Dunqing
force-pushed
the
12-05-test_transformer_update_fixtures_script_support_overrides
branch
from
December 8, 2024 01:43
13881e6
to
efaaa97
Compare
Dunqing
force-pushed
the
12-05-test_transformer_class-properties_override_fixtures
branch
from
December 8, 2024 01:43
aca4fd0
to
5fd1361
Compare
Base automatically changed from
12-05-test_transformer_update_fixtures_script_support_overrides
to
main
December 8, 2024 02:02
graphite-app
bot
deleted the
12-05-test_transformer_class-properties_override_fixtures
branch
December 8, 2024 02:03
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
0-merge
Merge with Graphite Merge Queue
A-transformer
Area - Transformer / Transpiler
C-test
Category - Testing. Code is missing test cases, or a PR is adding them
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Override some transform conformance test fixtures for class properties transform, where: