-
-
Notifications
You must be signed in to change notification settings - Fork 486
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(transformer): update fixtures script support overrides #7688
Merged
graphite-app
merged 1 commit into
main
from
12-05-test_transformer_update_fixtures_script_support_overrides
Dec 8, 2024
Merged
test(transformer): update fixtures script support overrides #7688
graphite-app
merged 1 commit into
main
from
12-05-test_transformer_update_fixtures_script_support_overrides
Dec 8, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Your org has enabled the Graphite merge queue for merging into mainAdd the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
github-actions
bot
added
the
C-test
Category - Testing. Code is missing test cases, or a PR is adding them
label
Dec 5, 2024
overlookmotel
force-pushed
the
12-05-test_transformer_update_fixtures_script_support_overrides
branch
3 times, most recently
from
December 6, 2024 18:09
05a1a76
to
d1ab894
Compare
This was referenced Dec 6, 2024
overlookmotel
force-pushed
the
12-05-test_transformer_update_fixtures_script_support_overrides
branch
from
December 7, 2024 18:59
d1ab894
to
13881e6
Compare
overlookmotel
changed the base branch from
main
to
12-05-test_transformer_class-properties_exec_test_for_this_in_computed_key
December 7, 2024 18:59
This was referenced Dec 7, 2024
Merge activity
|
Support overriding test fixtures in `update_fixtures.js` script. Any files in `tasks/transform_conformance/overrides` are copied into Babel test fixtures. If `options.json` is overridden, then script runs Babel with updated options, to generate a new `output` file for the fixture.
Dunqing
force-pushed
the
12-05-test_transformer_class-properties_exec_test_for_this_in_computed_key
branch
from
December 8, 2024 01:42
cda9512
to
da63e87
Compare
Dunqing
force-pushed
the
12-05-test_transformer_update_fixtures_script_support_overrides
branch
from
December 8, 2024 01:43
13881e6
to
efaaa97
Compare
Base automatically changed from
12-05-test_transformer_class-properties_exec_test_for_this_in_computed_key
to
main
December 8, 2024 01:57
graphite-app
bot
deleted the
12-05-test_transformer_update_fixtures_script_support_overrides
branch
December 8, 2024 02:02
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
0-merge
Merge with Graphite Merge Queue
A-transformer
Area - Transformer / Transpiler
C-test
Category - Testing. Code is missing test cases, or a PR is adding them
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support overriding test fixtures in
update_fixtures.js
script.Any files in
tasks/transform_conformance/overrides
are copied into Babel test fixtures. Ifoptions.json
is overridden, then script runs Babel with updated options, to generate a newoutput
file for the fixture.