Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(transformer/jsx): Pragma::parse take a &str #7619

Merged

Conversation

overlookmotel
Copy link
Contributor

@overlookmotel overlookmotel commented Dec 3, 2024

Pragma::parse take an Option<&str> instead of Option<&String>. Passing &Strings to functions is an odd pattern.

Copy link

graphite-app bot commented Dec 3, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Contributor Author

overlookmotel commented Dec 3, 2024

@github-actions github-actions bot added A-transformer Area - Transformer / Transpiler C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Dec 3, 2024
@overlookmotel overlookmotel marked this pull request as ready for review December 3, 2024 15:54
Copy link

codspeed-hq bot commented Dec 3, 2024

CodSpeed Performance Report

Merging #7619 will not alter performance

Comparing 12-03-refactor_transformer_jsx_pragma_parse_take_a_str_ (8ad52be) with main (fcc2546)

Summary

✅ 29 untouched benchmarks

@graphite-app graphite-app bot added the 0-merge Merge with Graphite Merge Queue label Dec 4, 2024
Copy link

graphite-app bot commented Dec 4, 2024

Merge activity

@Boshen Boshen force-pushed the 12-03-test_transformer_jsx_move_tests_setup_into_a_macro branch from af37f57 to 6c70b6c Compare December 4, 2024 02:08
@Boshen Boshen force-pushed the 12-03-refactor_transformer_jsx_pragma_parse_take_a_str_ branch from eb8bcdf to 171c635 Compare December 4, 2024 02:09
`Pragma::parse` take an `Option<&str>` instead of `Option<&String>`. Passing `&String`s to functions is an odd pattern.
@Boshen Boshen force-pushed the 12-03-test_transformer_jsx_move_tests_setup_into_a_macro branch from 6c70b6c to 2158c38 Compare December 4, 2024 02:47
@Boshen Boshen force-pushed the 12-03-refactor_transformer_jsx_pragma_parse_take_a_str_ branch from 171c635 to 8ad52be Compare December 4, 2024 02:48
Base automatically changed from 12-03-test_transformer_jsx_move_tests_setup_into_a_macro to main December 4, 2024 02:52
@graphite-app graphite-app bot merged commit 8ad52be into main Dec 4, 2024
25 checks passed
@graphite-app graphite-app bot deleted the 12-03-refactor_transformer_jsx_pragma_parse_take_a_str_ branch December 4, 2024 02:56
@oxc-bot oxc-bot mentioned this pull request Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0-merge Merge with Graphite Merge Queue A-transformer Area - Transformer / Transpiler C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant