Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(transformer/jsx): move tests setup into a macro #7618

Merged

Conversation

overlookmotel
Copy link
Contributor

@overlookmotel overlookmotel commented Dec 3, 2024

Follow up after #7553. Move tests setup for JSX pragmas into a macro to prevent tests having access to an owned TraverseCtx, for safety.

Copy link

graphite-app bot commented Dec 3, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added the A-transformer Area - Transformer / Transpiler label Dec 3, 2024
@github-actions github-actions bot added the C-test Category - Testing. Code is missing test cases, or a PR is adding them label Dec 3, 2024
@overlookmotel overlookmotel marked this pull request as ready for review December 3, 2024 15:53
Copy link

codspeed-hq bot commented Dec 3, 2024

CodSpeed Performance Report

Merging #7618 will not alter performance

Comparing 12-03-test_transformer_jsx_move_tests_setup_into_a_macro (2158c38) with main (fcc2546)

Summary

✅ 29 untouched benchmarks

@overlookmotel
Copy link
Contributor Author

overlookmotel commented Dec 3, 2024

@Boshen Any idea why the Test NAPI CI task is failing? Is it genuine, or perhaps related to recent changes to NAPI?

This PR is meant to be pure refactor. I don't think it should affect anything. And pnpm run build && pnpm run test completes locally with no errors.

@graphite-app graphite-app bot added the 0-merge Merge with Graphite Merge Queue label Dec 4, 2024
Copy link

graphite-app bot commented Dec 4, 2024

Merge activity

@Boshen Boshen force-pushed the 12-03-test_transformer_jsx_move_tests_setup_into_a_macro branch from af37f57 to 6c70b6c Compare December 4, 2024 02:08
Follow up after #7553. Move tests setup for JSX pragmas into a macro to prevent tests having access to an owned `TraverseCtx`, for safety.
@Boshen Boshen force-pushed the 12-03-test_transformer_jsx_move_tests_setup_into_a_macro branch from 6c70b6c to 2158c38 Compare December 4, 2024 02:47
@graphite-app graphite-app bot merged commit 2158c38 into main Dec 4, 2024
24 checks passed
@graphite-app graphite-app bot deleted the 12-03-test_transformer_jsx_move_tests_setup_into_a_macro branch December 4, 2024 02:52
@overlookmotel
Copy link
Contributor Author

Failing Test NAPI CI task was unrelated to this PR.

@oxc-bot oxc-bot mentioned this pull request Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0-merge Merge with Graphite Merge Queue A-transformer Area - Transformer / Transpiler C-test Category - Testing. Code is missing test cases, or a PR is adding them
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant