Fix routes #15915
Merged
Fix routes #15915
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes public sharing as reported on #15913
|
A new inspection was created. |
|
Opening public link works now 👍 |
|
test? me hides |
|
Lukas said it here: #15913 (comment) |
|
I though we could just include the file, but we would need to call all those closures... didnt see them in first place |
|
Refer to this link for build results (access rights to CI server needed): |
|
Makes sense 👍 |
|
Please somebody open a tech dept on unit testing routes.php and app.php - maybe we find a solution .... THX |
mmattel
pushed a commit
to mmattel/core
that referenced
this pull request
May 22, 2015
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #15913
@icewind1991 Please review and test. Thx.