Public sharing broken on master

[LukasReschke]

@icewind1991 While fixing the namespace in https://github.com/owncloud/core/blob/557b4a2cb0ae0367e5facb1e4be136de07ab8cff/apps/files_sharing/appinfo/application.php you broke public sharing in core completely, please take a look at

core/core/routes.php

Lines 111 to 126 in 557b4a2

	$this->create('files_sharing.sharecontroller.showShare', '/s/{token}')->action(function($urlParams) {
	$app = new \OCA\Files_Sharing\Application($urlParams);
	$app->dispatch('ShareController', 'showShare');
	});
	$this->create('files_sharing.sharecontroller.authenticate', '/s/{token}/authenticate')->post()->action(function($urlParams) {
	$app = new \OCA\Files_Sharing\Application($urlParams);
	$app->dispatch('ShareController', 'authenticate');
	});
	$this->create('files_sharing.sharecontroller.showAuthenticate', '/s/{token}/authenticate')->get()->action(function($urlParams) {
	$app = new \OCA\Files_Sharing\Application($urlParams);
	$app->dispatch('ShareController', 'showAuthenticate');
	});
	$this->create('files_sharing.sharecontroller.downloadShare', '/s/{token}/download')->get()->action(function($urlParams) {
	$app = new \OCA\Files_Sharing\Application($urlParams);
	$app->dispatch('ShareController', 'downloadShare');
	});

Regression by the ETag PR from #14764

[LukasReschke]

Wondering if Scrutinizer should have catched that, waiting for analysis as per #14764 (comment)

@DeepDiver1975 Anything we can do to catch such stuff on Jenkins?

[LukasReschke]

PR is at #15915

[DeepDiver1975]

@DeepDiver1975 Anything we can do to catch such stuff on Jenkins?

unit tests

[LukasReschke]

unit tests

Of the routing file? – Long way to go 🙈