Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable7] Fix size propagation over shared storage boundary #14861

Merged
merged 5 commits into from
Mar 26, 2015

Conversation

PVince81
Copy link
Contributor

Backport of #14720 to stable7

@icewind1991 @nickvergessen @MorrisJobke

(there were merge conflicts)

@PVince81 PVince81 added this to the 7.0.6-current-maintenance milestone Mar 13, 2015
@PVince81
Copy link
Contributor Author

Had a quick manual test, it works.

I'll fix the unit test.

@PVince81
Copy link
Contributor Author

Having trouble with the unit tests.
It looks like on stable7 there is a stat cache issue. When re-reading the filesize after simulated upload, it still returns the old size. I need to add an explicit clearstatcache($fullPath) here https://github.com/owncloud/core/blob/stable7/lib/private/files/storage/local.php#L113 to make it work.

I'll try and find out why it works on master... maybe something else needs backporting.

@PVince81
Copy link
Contributor Author

Okay, it seems that backporting #10881 would fix it.
Even though that linked PR is about clearstatcache for mtime, it has the side effect of also making it work for the size...

@scrutinizer-notifier
Copy link

A new inspection was created.

@PVince81
Copy link
Contributor Author

I have now backported the commits from #10881 (comment) here, let me know if this is ok.

@scrutinizer-notifier
Copy link

The inspection completed: 3 new issues, 4 updated code elements

@karlitschek
Copy link
Contributor

backport is fine. 👍

@PVince81
Copy link
Contributor Author

A Jenkins PR even for stable7 ?! Pffff...
Maybe I should stop pushing furiously.

Here it is: #14934

@PVince81
Copy link
Contributor Author

Please review

@PVince81
Copy link
Contributor Author

Test steps here: #14596 (comment)

@MorrisJobke
Copy link
Contributor

Tested and works 👍

MorrisJobke added a commit that referenced this pull request Mar 26, 2015
…thshare

[stable7] Fix size propagation over shared storage boundary
@MorrisJobke MorrisJobke merged commit ef1ddfc into stable7 Mar 26, 2015
@MorrisJobke MorrisJobke deleted the stable7-fix-sizepropagationwithshare branch March 26, 2015 19:14
@lock lock bot locked as resolved and limited conversation to collaborators Aug 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants