Fix size propagation over shared storage boundary

[PVince81]

Fix size propagation for #14596

• propagate sizes over shared storage boundary
• unit test

@icewind1991 FYI

[PVince81]

@icewind1991 I wonder if at some point we should move size calculation to the propagator classes

[PVince81]

It turns out size propagation is easy but etag/mtime propagation is hard.

The "Updater" class is based on the current user's view, so it's not possible to make it work on another user's view without setupFS gymnastics... I also tried to instantiate a ChangePropagator from the SharedScanner, but that's another code path and isn't triggered.

@icewind1991 any suggestion how to make this work ?
If it's too complicated I might split this into a separate PR so we can at least get the size stuff in...

[PVince81]

Keep in mind that the fix needs to be backportable to OC 7...

[PVince81]

Let's keep this here only for the size propagation.
Etag propagation is another story, to be looked into separately: #14726

[luizluca]

@PVince81 , I just tested and it works for me :-)
Thanks,

[PVince81]

Great to hear that, thanks for testing.

I still need to write a unit test to finish this PR.

[PVince81]

...that assuming that @icewind1991 is fine with the approach I used.

[PVince81]

Just had a go at a unit test locally and the bad news is that it seems to propagate wrong.

Whenever a share recipient changes a file, the size should be propagated to the owner's root, NOT to the recipient's root. The propagation must stop at the shared folder and not go further. It doesn't seem to be the case at the moment. This means that the size would be counted twice, once for each user, which is wrong.

[PVince81]

Hmmm, I tried this manually and the propagation seems to work properly. The recipient's root size stays the same. Maybe something is wrong in the unit test then.

[scrutinizer-notifier]

A new inspection was created.

[PVince81]

Ok fixed the unit test.
The mistake is that I used getFileInfo($path) which automatically includes the size of mount points.
The proper call is getFileInfo($path, false) to get what's in the DB.

[PVince81]

Test steps are here: #14596 (comment)

[ghost]

Refer to this link for build results (access rights to CI server needed):
https://ci.owncloud.org//job/pull-request-analyser-ng-simple/10274/
Test PASSed.

[PVince81]

Please review @icewind1991 @DeepDiver1975 @MorrisJobke @nickvergessen @schiesbn

The patch was tested by the original reporter here #14720 (comment)

[icewind1991]

Looks good 👍

[MorrisJobke]

Tested & works:+1:

[PVince81]

@karlitschek backport to OC 7 and OC 8 ? (for 7.0.7 and 8.0.3)
Size propagation / quota calculation is broken since OC 7 with shares

[karlitschek]

Please backport once 8.0.2 and 7.0.5 are done :-) 👍

[PVince81]

Preparing backport PRs now.

[PVince81]

stable8: #14860
stable7: #14861