Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT Deprecated pandas.DataFrameGroupBy.grouper #332

Merged
merged 4 commits into from
Nov 19, 2024

Conversation

BorisMuzellec
Copy link
Collaborator

What does your PR implement? Be specific.

FutureWarnings were ignored in the CI, which is not good practice. They are no longer ignored by default.

pandas.DataFrameGroupBy.grouper is now deprecated. This PR replaces it with a call to ngroup().

It also handles a warning due to changes in rcond default argument value in np.linalg.lstsq().

Two Futurewarnings were specifically ignored, as they will potentially no longer be relevant after #328 is merged.

Copy link
Collaborator

@umarteauowkin umarteauowkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks :)

@BorisMuzellec BorisMuzellec merged commit 0a0e316 into main Nov 19, 2024
9 checks passed
@BorisMuzellec BorisMuzellec deleted the fix/pandas_depr_groupby branch November 19, 2024 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants