🐛 (facet) make legend clickable for line and slope charts only #4370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sophiamersmann
force-pushed
the
fix-facet-legend-clicks
branch
from
22a2283 to
3a094c8
Compare
sophiamersmann
changed the base branch from
refatcor-horizontal-color-legend
to
master
|
Quick links (staging server):
Login:
SVG tester:Number of differences (default views): 0 ✅ Edited: 2025-01-02 14:27:31 UTC |
sophiamersmann
force-pushed
the
fix-facet-legend-clicks
branch
from
fb3ebba to
5011717
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clicking categorical facet legends focuses all entities that are contained within the clicked legend item. Since focus mode is only supported for line and slope charts, facet legends for other chart types shouldn't be clickable.