🔨 drop manager pattern for horizontal color legend #4369
+1,443
−1,204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Jan 2, 2025
|
Quick links (staging server):
Login:
SVG tester:Number of differences (default views): 0 ✅ Edited: 2025-01-03 15:34:12 UTC |
sophiamersmann
force-pushed
the
refactor-vertical-color-legend
branch
from
ae13f91 to
eb5c12d
Compare
sophiamersmann
force-pushed
the
refatcor-horizontal-color-legend
branch
from
90e51d2 to
1e443c5
Compare
sophiamersmann
force-pushed
the
refactor-vertical-color-legend
branch
from
eb5c12d to
f061537
Compare
sophiamersmann
force-pushed
the
refatcor-horizontal-color-legend
branch
from
78c8b85 to
3441962
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drops the 'manager pattern' for horizontal colour legend components.
See #4368 for a more general discussion
Changes
This PR splits
HorizontalNumericColorLegendandHorizontalCategoricalColorLegendeach into a state class and a rendering component.