Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/manager 15473 #14252

Open
wants to merge 18 commits into
base: feat/procedures-gdpr
Choose a base branch
from
Open

Feat/manager 15473 #14252

wants to merge 18 commits into from
+1,674 −309

Conversation

JacquesLarique
Copy link
Contributor

Question Answer
Branch? feat/procedures-gdpr
Bug fix? no
New feature? yes
Breaking change? no
Tickets MANAGER-15473
License BSD 3-Clause
  • Try to keep pull requests small so they can be easily reviewed.
  • Commits are signed-off
  • Only FR translations have been updated (n/a)
  • Branch is up-to-date with target branch
  • Lint has passed locally
  • Standalone app was ran and tested locally
  • Ticket reference is mentioned in linked commits (internal only)
  • Breaking change is mentioned in relevant commits (n/a)

Description

Adapted workflow to match changes in API contract interface (url in lowercase and nichandle not nullable)

Related

oalkabouss and others added 18 commits October 28, 2024 10:41
@oalkabouss
feat(procedures): created gdpr page (#13477)
bca70e6 
ref:MANAGER-15312

Signed-off-by: Omar ALKABOUSS MOUSSANA <[email protected]>
@oalkabouss
feat(procedures): implement gdpr form introduction (#13491)
01307de 
ref: MANAGER-15315

Signed-off-by: Omar ALKABOUSS MOUSSANA <[email protected]>
@oalkabouss
feat(procedures): implement redirection to website for gdpr (#13596)
ce5392d 
ref: MANAGER-15312

Signed-off-by: Omar ALKABOUSS MOUSSANA <[email protected]>
@oalkabouss
feat(procedures): implemented gdpr form (#13558)
6556b7f 
ref:MANAGER-15317

Signed-off-by: Omar ALKABOUSS MOUSSANA <[email protected]>
@oalkabouss
feat(procedures): rgpd add legal notice component (#13611)
2f6cc35 
ref: MANAGER-15376

Signed-off-by: Omar ALKABOUSS MOUSSANA <[email protected]>
@oalkabouss
feat(procedures): gdpr implementation of document upload (#13581)
899e79d 
ref: MANAGER-15339

Signed-off-by: Omar ALKABOUSS MOUSSANA <[email protected]>
@oalkabouss
fix(procedures): adjustments to gdpr form (#13658)
d989645 
ref: MANAGER-15317

Signed-off-by: Omar ALKABOUSS MOUSSANA <[email protected]>
@oalkabouss
feat(procedures): implement gdpr document upload and confirmation (#1…
506ab67 
…3654)

ref: MANAGER-15368

Signed-off-by: Omar ALKABOUSS MOUSSANA <[email protected]>
@oalkabouss
fix(procedures): fix filename overflow for mobile (#13712)
12047a9 
ref: MANAGER-15339

Signed-off-by: Omar ALKABOUSS MOUSSANA <[email protected]>
@oalkabouss
fix(procedures): gdpr fix wording & api call with mock (#13801)
48ce303 
ref: MANAGER-15368

Signed-off-by: Omar ALKABOUSS MOUSSANA <[email protected]>
@oalkabouss
feat(procedures): gdpr fix label wording & removes id document field (#…
fc9b98b 
…13873)

ref: MANAGER-15725d

Signed-off-by: Omar ALKABOUSS MOUSSANA <[email protected]>
@oalkabouss
fix(procedures): gdpr fix field category detail wording (#13910)
23fcdef 
ref: MANAGER-15725

Signed-off-by: Omar ALKABOUSS MOUSSANA <[email protected]>
@oalkabouss
fix(procedures): gdpr fix error message (#13966)
05beac0 
ref: MANAGER-15725

Signed-off-by: Omar ALKABOUSS MOUSSANA <[email protected]>
@oalkabouss
feat(procedures): dgpr removal of mocks (#13934)
c56d686 
ref: MANAGER-15473

Signed-off-by: Omar ALKABOUSS MOUSSANA <[email protected]>
@oalkabouss
fix(procedures): gdpr transmit the email in the finalize api body (#1…
565c36f 
…4036)

ref: MANAGER-15473

Signed-off-by: Omar ALKABOUSS MOUSSANA <[email protected]>
@oalkabouss
fix(procedures): gdpr form fixed issue preventing selection of reason (…
4f94308 
…#14084)

ref: MANAGER-15932

Signed-off-by: Omar ALKABOUSS MOUSSANA <[email protected]>
feat(procedures): updated gdpr api url
9daf938 
ref: MANAGER-15473

Signed-off-by: Jacques Larique <[email protected]>
feat(procedures): removed nichandle from body if it is null
aa4da78 
ref: MANAGER-15473

Signed-off-by: Jacques Larique <[email protected]>
@JacquesLarique JacquesLarique requested review from a team as code owners November 25, 2024 14:01
@JacquesLarique JacquesLarique requested review from sidlynx, frenautvh, qpavy, sachinrameshn and mhelhali-soufien and removed request for a team November 25, 2024 14:01
@github-actions github-actions bot added the feature New feature label Nov 25, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 25, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@github-actions github-actions bot added the has conflicts Has conflicts to resolve before merging label Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sidlynx sidlynx Awaiting requested review from sidlynx sidlynx is a code owner automatically assigned from ovh/su-digital-tools-core-stack

@frenautvh frenautvh Awaiting requested review from frenautvh frenautvh is a code owner automatically assigned from ovh/su-digital-tools-core-stack

@qpavy qpavy Awaiting requested review from qpavy qpavy is a code owner automatically assigned from ovh/team-manager-dev-angularjs

@sachinrameshn sachinrameshn Awaiting requested review from sachinrameshn sachinrameshn is a code owner automatically assigned from ovh/team-manager-dev-angularjs

@mhelhali-soufien mhelhali-soufien Awaiting requested review from mhelhali-soufien mhelhali-soufien is a code owner automatically assigned from ovh/team-manager-dev-angularjs

Assignees
No one assigned
Labels
feature New feature has conflicts Has conflicts to resolve before merging
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JacquesLarique @oalkabouss